Skip to content

Commit aab6608

Browse files
authored
fix(getmessages): ZMS-260: messages.js getMessages allow unseen request flag to be false (#861)
* messages.js allow unseen request flag to be false to allow search for seen messages only * messages.js check filterUnseen type instead of just checking for undefined
1 parent 3d8db38 commit aab6608

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

lib/api/messages.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,9 @@ module.exports = (db, server, messageHandler, userHandler, storageHandler, setti
321321
mailbox: Joi.string().hex().lowercase().length(24).required().description('ID of the Mailbox')
322322
},
323323
queryParams: {
324-
unseen: booleanSchema.description('If true, then returns only unseen messages'),
324+
unseen: booleanSchema.description(
325+
'If true, then returns only unseen messages. If false, then returs only seen messages. Leave blank to return all messages'
326+
),
325327
metaData: booleanSchema.default(false).description('If true, then includes metaData in the response'),
326328
threadCounters: booleanSchema
327329
.default(false)
@@ -472,7 +474,7 @@ module.exports = (db, server, messageHandler, userHandler, storageHandler, setti
472474
let pageNext = result.value.next;
473475
let pagePrevious = result.value.previous;
474476
let sortAscending = result.value.order === 'asc';
475-
let filterUnseen = result.value.unseen;
477+
const filterUnseen = result.value.unseen;
476478

477479
let includeHeaders = result.value.includeHeaders ? result.value.includeHeaders.split(',') : false;
478480

@@ -511,8 +513,8 @@ module.exports = (db, server, messageHandler, userHandler, storageHandler, setti
511513
mailbox
512514
};
513515

514-
if (filterUnseen) {
515-
filter.unseen = true;
516+
if (typeof filterUnseen === 'boolean') {
517+
filter.unseen = filterUnseen;
516518
}
517519

518520
let total = await getFilteredMessageCount(filter);

0 commit comments

Comments
 (0)