Skip to content

Commit 5f36f39

Browse files
committed
Update MySQL
1 parent 07f9d36 commit 5f36f39

File tree

6 files changed

+13
-15
lines changed

6 files changed

+13
-15
lines changed

build.gradle

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ ext {
6565
[name: '2022', 'mssql': '2022-latest', 'mssql-driver': 'default']
6666
]],
6767
[name: 'mysql', versions: [
68-
[name: '5.7', 'mysql': '5.7', 'mysql-driver': 'default'],
69-
[name: '8.2', 'mysql': '8.2', 'mysql-driver': 'default']
68+
[name: '8.4', 'mysql': '8.4', 'mysql-driver': 'default'],
69+
[name: '9.0', 'mysql': '9.0', 'mysql-driver': 'default']
7070
]],
7171
[name: 'mariadb', versions: [
7272
[name: '10.11', 'mariadb': '10.11', 'mariadb-driver': '2.7.12'],
@@ -268,7 +268,7 @@ project(':embedded-database-spring-test') {
268268

269269
optImplementation 'org.postgresql:postgresql:42.7.3'
270270
optImplementation 'com.microsoft.sqlserver:mssql-jdbc:12.8.0.jre8'
271-
optImplementation 'mysql:mysql-connector-java:8.0.33'
271+
optImplementation 'com.mysql:mysql-connector-j:9.0.0'
272272
optImplementation 'org.mariadb.jdbc:mariadb-java-client:3.4.1'
273273
optImplementation 'com.h2database:h2:2.2.224'
274274
optImplementation 'org.hsqldb:hsqldb:2.5.2'
@@ -427,9 +427,10 @@ project(':embedded-database-spring-test') {
427427

428428
if (version['mysql-driver'] == null) { // optional dependencies are implicitly excluded
429429
exclude group: 'mysql', module: 'mysql-connector-java'
430+
exclude group: 'com.mysql', module: 'mysql-connector-j'
430431
} else if (version['mysql-driver'] != 'default') {
431432
eachDependency { details ->
432-
if (details.requested.group == 'mysql' && details.requested.name == 'mysql-connector-java') {
433+
if (details.requested.group == 'com.mysql' && details.requested.name == 'mysql-connector-j') {
433434
details.useVersion "${version['mysql-driver']}"
434435
}
435436
}

embedded-database-spring-test/src/main/java/io/zonky/test/db/config/EmbeddedDatabaseAutoConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ public DatabaseProvider dockerMsSqlDatabaseProvider(DatabaseProviderFactory msSq
104104
@ConditionalOnMissingBean(name = "dockerMySqlDatabaseProvider")
105105
public DatabaseProvider dockerMySqlDatabaseProvider(DatabaseProviderFactory mySqlDatabaseProviderFactory) {
106106
checkDependency("org.testcontainers", "mysql", "org.testcontainers.containers.MySQLContainer");
107-
checkDependency("mysql", "mysql-connector-java", "com.mysql.cj.jdbc.MysqlDataSource");
107+
checkDependency("com.mysql", "mysql-connector-j", "com.mysql.cj.jdbc.MysqlDataSource");
108108
return mySqlDatabaseProviderFactory.createProvider(DockerMySQLDatabaseProvider.class);
109109
}
110110

embedded-database-spring-test/src/main/java/io/zonky/test/db/provider/mysql/DockerMySQLDatabaseProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public DatabasePool load(DatabaseConfig config) {
7575
private final ClientConfig clientConfig;
7676

7777
public DockerMySQLDatabaseProvider(Environment environment, ObjectProvider<List<MySQLContainerCustomizer>> containerCustomizers) {
78-
String dockerImage = environment.getProperty("zonky.test.database.mysql.docker.image", "mysql:8.4");
78+
String dockerImage = environment.getProperty("zonky.test.database.mysql.docker.image", "mysql:9.0");
7979
String tmpfsOptions = environment.getProperty("zonky.test.database.mysql.docker.tmpfs.options", "rw,noexec,nosuid");
8080
boolean tmpfsEnabled = environment.getProperty("zonky.test.database.mysql.docker.tmpfs.enabled", boolean.class, false);
8181

embedded-database-spring-test/src/main/resources/META-INF/spring-configuration-metadata.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@
153153
"name": "zonky.test.database.mysql.docker.image",
154154
"type": "java.lang.String",
155155
"description": "Docker image containing MySQL database.",
156-
"defaultValue": "mysql:5.7"
156+
"defaultValue": "mysql:9.0"
157157
},
158158
{
159159
"name": "zonky.test.database.mysql.docker.tmpfs.enabled",
@@ -352,9 +352,6 @@
352352
},
353353
{
354354
"value": "mysql:8.0"
355-
},
356-
{
357-
"value": "mysql:5.7"
358355
}
359356
],
360357
"providers": [

embedded-database-spring-test/src/test/java/io/zonky/test/db/provider/DockerMySQLProviderWithConfigurationIntegrationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
@AutoConfigureEmbeddedDatabase(type = MYSQL)
4343
@ContextConfiguration
4444
@TestPropertySource(properties = {
45-
"zonky.test.database.mysql.docker.image=mysql:5.6.48"
45+
"zonky.test.database.mysql.docker.image=mysql:9.0"
4646
})
4747
public class DockerMySQLProviderWithConfigurationIntegrationTest {
4848

@@ -64,6 +64,6 @@ public void testDataSource() throws SQLException {
6464

6565
JdbcTemplate jdbcTemplate = new JdbcTemplate(dataSource);
6666
String databaseVersion = jdbcTemplate.queryForObject("select @@version", String.class);
67-
assertThat(databaseVersion).startsWith("5.6.48");
67+
assertThat(databaseVersion).startsWith("9.0");
6868
}
6969
}

embedded-database-spring-test/src/test/java/io/zonky/test/db/provider/mysql/DockerMySQLDatabaseProviderTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ public void providersWithDifferentCustomizersShouldNotEquals() {
168168
@Test
169169
public void testConfigurationProperties() throws Exception {
170170
MockEnvironment environment = new MockEnvironment();
171-
environment.setProperty("zonky.test.database.mysql.docker.image", "mysql:5.6.48");
171+
environment.setProperty("zonky.test.database.mysql.docker.image", "mysql:9.0");
172172
environment.setProperty("zonky.test.database.mysql.client.properties.socketTimeout", "30");
173173
environment.setProperty("zonky.test.database.mysql.client.properties.description", "test description");
174174
environment.setProperty("zonky.test.database.mysql.client.properties.autoReconnect", "true");
@@ -184,7 +184,7 @@ public void testConfigurationProperties() throws Exception {
184184
JdbcTemplate jdbcTemplate = new JdbcTemplate(dataSource);
185185

186186
String databaseVersion = jdbcTemplate.queryForObject("select @@version", String.class);
187-
assertThat(databaseVersion).startsWith("5.6.48");
187+
assertThat(databaseVersion).startsWith("9.0");
188188

189189
String maxConnections = jdbcTemplate.queryForObject("select @@max_connections", String.class);
190190
assertThat(maxConnections).isEqualTo("151");
@@ -247,4 +247,4 @@ private static int getPort(DataSource dataSource) throws SQLException {
247247
private static MySQLContainerCustomizer mysqlContainerCustomizer(long timeout) {
248248
return container -> container.withStartupTimeout(Duration.ofSeconds(timeout));
249249
}
250-
}
250+
}

0 commit comments

Comments
 (0)