Clean up socket resource closure

Author: stevenschlansker

src/main/java/io/zonky/test/db/postgres/embedded/EmbeddedPostgres.java

@@ -24,8 +24,6 @@
 import java.net.InetSocketAddress;
 import java.net.ServerSocket;
 import java.net.Socket;
-import java.net.SocketException;
-import java.net.UnknownHostException;
 import java.nio.ByteBuffer;
 import java.nio.channels.AsynchronousFileChannel;
 import java.nio.channels.Channel;
@@ -328,28 +326,12 @@ private void waitForServerStartup(StopWatch watch) throws IOException
 
     private void verifyReady() throws SQLException
     {
-        final InetAddress localhost;
-        try {
-            localhost = InetAddress.getByAddress(new byte[]{127, 0, 0, 1});
-        } catch (final UnknownHostException e) {
-            throw new AssertionError("localhost unknown?", e);
-        }
-        final Socket sock = new Socket();
-        try {
+        final InetAddress localhost = InetAddress.getLoopbackAddress();
+        try (Socket sock = new Socket()) {
             sock.setSoTimeout((int) Duration.ofMillis(500).toMillis());
-        } catch (final SocketException e) {
-            throw new RuntimeException("error setting socket timeout", e);
-        }
-        try {
             sock.connect(new InetSocketAddress(localhost, port), (int) Duration.ofMillis(500).toMillis());
         } catch (final IOException e) {
             throw new SQLException("connect failed", e);
-        } finally {
-            try {
-                sock.close();
-            } catch (final IOException e) {
-                LOG.trace("i/o exception closing test socket", e);
-            }
         }
         try (Connection c = getPostgresDatabase().getConnection() ;
                 Statement s = c.createStatement() ;