Skip to content

Commit bbd1afd

Browse files
committed
Use settings for extra prechat info and form details
1 parent 2db97ca commit bbd1afd

File tree

2 files changed

+5
-15
lines changed

2 files changed

+5
-15
lines changed

addon/services/liveagent.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,8 @@ export default class LiveAgentService extends Service {
7373
svc.settings.storageDomain = domain;
7474
}
7575

76-
svc.snippetSettingsFile.extraPrechatFormDetails = extraPrechatFormDetails;
77-
svc.snippetSettingsFile.extraPrechatInfo = extraPrechatInfo;
76+
svc.settings.extraPrechatFormDetails = extraPrechatFormDetails;
77+
svc.settings.extraPrechatInfo = extraPrechatInfo;
7878

7979
svc.init(
8080
salesforceURL,

tests/unit/services/liveagent-test.js

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,10 @@ module('Unit | Service | liveagent', function (hooks) {
1313
hooks.afterEach(clear);
1414

1515
test('it boots', function (assert) {
16-
assert.expect(9);
16+
assert.expect(8);
1717

1818
window.embedded_svc = {
1919
settings: {},
20-
snippetSettingsFile: {},
2120
init() {
2221
assert.strictEqual(arguments.length, 6);
2322
assert.strictEqual(arguments[0], 'test://salesforceURL');
@@ -48,20 +47,16 @@ module('Unit | Service | liveagent', function (hooks) {
4847
loadingText: 'Loading',
4948
offlineSupportMinimizedText: 'Contact Us',
5049
prepopulatedPrechatFields: {},
51-
});
52-
53-
assert.deepEqual(window.embedded_svc.snippetSettingsFile, {
5450
extraPrechatFormDetails: [],
5551
extraPrechatInfo: [],
5652
});
5753
});
5854

5955
test('it boots with custom options', function (assert) {
60-
assert.expect(9);
56+
assert.expect(8);
6157

6258
window.embedded_svc = {
6359
settings: {},
64-
snippetSettingsFile: {},
6560
init() {
6661
assert.strictEqual(arguments.length, 6);
6762
assert.strictEqual(arguments[0], 'test://salesforceURL');
@@ -109,20 +104,16 @@ module('Unit | Service | liveagent', function (hooks) {
109104
field: 'custom://prepopulatedPrechatFields',
110105
},
111106
storageDomain: 'custom://domain',
112-
});
113-
114-
assert.deepEqual(window.embedded_svc.snippetSettingsFile, {
115107
extraPrechatFormDetails: ['custom://extraPrechatFormDetails'],
116108
extraPrechatInfo: ['custom://extraPrechatInfo'],
117109
});
118110
});
119111

120112
test('it does not boot in FastBoot', function (assert) {
121-
assert.expect(2);
113+
assert.expect(1);
122114

123115
window.embedded_svc = {
124116
settings: {},
125-
snippetSettingsFile: {},
126117
init() {
127118
assert.ok(false);
128119
},
@@ -134,6 +125,5 @@ module('Unit | Service | liveagent', function (hooks) {
134125
service.boot();
135126

136127
assert.deepEqual(window.embedded_svc.settings, {});
137-
assert.deepEqual(window.embedded_svc.snippetSettingsFile, {});
138128
});
139129
});

0 commit comments

Comments
 (0)