Fix two crashes, lint warnings and an errant log message. Bump to v43 in anticipation of release

Author: arashpayan

app/build.gradle

@@ -11,8 +11,8 @@ android {
         compileSdk 34
         minSdkVersion 29
         targetSdkVersion 34
-        versionCode 42
-        versionName "0.42"
+        versionCode 43
+        versionName "0.43"
         multiDexEnabled true
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         resourceConfigurations += ['en']

app/src/main/java/io/pijun/george/MessageProcessor.java

@@ -32,6 +32,7 @@
 import io.pijun.george.queue.PersistentQueue;
 import retrofit2.Response;
 import xyz.zood.george.AvatarManager;
+import xyz.zood.george.Permissions;
 import xyz.zood.george.service.LocationService;
 import xyz.zood.george.service.ScreamerService;
 import xyz.zood.george.worker.BackupDatabaseWorker;
@@ -348,6 +349,17 @@ private static Result handleLocationUpdateRequest(@NonNull Context context, @Non
             return Result.Success;
         }
 
+        // does the app have background location permission?
+        if (!Permissions.checkBackgroundLocationPermission(context)) {
+            // we don't, so just inform the requester that we're done providing updates
+            UserComm done = UserComm.newLocationUpdateRequestReceived(UserComm.LOCATION_UPDATE_REQUEST_ACTION_FINISHED);
+            String errMsg = OscarClient.immediatelySendMessage(userRecord, accessToken, keyPair, done, true, true);
+            if (errMsg != null) {
+                L.w(errMsg);
+            }
+            return Result.Success;
+        }
+
         // Only perform the update if it's been more than 3 minutes since the last one
         // and the app isn't in the foreground
         long timeSinceUpdate = System.currentTimeMillis() - updateTime;

app/src/main/java/io/pijun/george/Utils.java

@@ -116,13 +116,13 @@ public static boolean isValidEmail(String email) {
         }
 
         String local = parts[0];
-        if (local.length() == 0 || local.length() > 64) {
+        if (local.isEmpty() || local.length() > 64) {
             return false;
         }
 
         // check if we have the format of a domain
         String domain = parts[1];
-        if (domain.length() == 0 || domain.length() > 255) {
+        if (domain.isEmpty() || domain.length() > 255) {
             return false;
         }
         String[] domainParts = domain.split("\\.");

app/src/main/java/io/pijun/george/WelcomeActivity.java

@@ -357,7 +357,6 @@ public void onRegisterAction() {
 
         final Editable password = binding.regPassword.getText();
         if (password == null || password.length() < Constants.PASSWORD_TEXT_MIN_LENGTH) {
-            L.i("reg password: '" + password + "'");
             binding.regPasswordContainer.setError(getString(R.string.too_short));
             foundError = true;
         }

app/src/main/java/io/pijun/george/api/OscarSocket.java

@@ -110,7 +110,9 @@ public void run() {
     @AnyThread
     public void disconnect() {
         L.i("socket.cancel");
-        socket.cancel();
+        if (socket != null) {
+            socket.cancel();
+        }
     }
 
     @AnyThread

app/src/main/java/xyz/zood/george/service/LocationService.java

@@ -112,6 +112,7 @@ private void startForegroundService() {
         Notification notification = new NotificationCompat.Builder(this, FINDING_LOCATION_CHANNEL_ID)
                 .setContentTitle(getString(R.string.finding_your_location))
                 .setSmallIcon(R.drawable.ic_position_service)
+                .setForegroundServiceBehavior(NotificationCompat.FOREGROUND_SERVICE_IMMEDIATE)
                 .build();
         startForeground(NOTIFICATION_ID, notification, ServiceInfo.FOREGROUND_SERVICE_TYPE_LOCATION);
     }