Avoid CaseClouseError when an update does not modify the document (#135)

Author: carlosliracl

lib/mongo/repo.ex

@@ -75,7 +75,7 @@ defmodule Mongo.Repo do
 
           case Mongo.update_one(@topology, collection, %{_id: id}, %{"$set" => module.dump(doc)}, []) do
             {:error, reason} -> {:error, reason}
-            {:ok, %{modified_count: 1}} -> {:ok, doc}
+            {:ok, %{modified_count: _}} -> {:ok, doc}
           end
         end
 
@@ -85,7 +85,7 @@ defmodule Mongo.Repo do
           case Mongo.update_one(@topology, collection, %{_id: id}, %{"$set" => module.dump(doc)}, upsert: true) do
             {:error, reason} -> {:error, reason}
             {:ok, %{upserted_ids: [id]}} -> {:ok, %{doc | _id: id}}
-            {:ok, %{modified_count: 1}} -> {:ok, doc}
+            {:ok, %{modified_count: _}} -> {:ok, doc}
           end
         end
 
@@ -117,7 +117,7 @@ defmodule Mongo.Repo do
 
           case update_one_result do
             %{upserted_ids: [id]} -> %{doc | _id: id}
-            %{modified_count: 1} -> doc
+            %{modified_count: _} -> doc
           end
         end
 

test/mongo/repo_test.exs

@@ -348,6 +348,15 @@ defmodule Mongo.RepoTest do
         |> Map.put(:title, "updated")
         |> MyRepo.update()
     end
+
+    test "updates a document without changes" do
+      {:ok, post} =
+        Post.new()
+        |> Map.put(:title, "test")
+        |> MyRepo.insert()
+
+      {:ok, %Post{title: "test"}} = MyRepo.update(post)
+    end
   end
 
   describe "update!/1" do
@@ -362,6 +371,15 @@ defmodule Mongo.RepoTest do
         |> Map.put(:title, "updated")
         |> MyRepo.update!()
     end
+
+    test "updates a document without changes" do
+      {:ok, post} =
+        Post.new()
+        |> Map.put(:title, "test")
+        |> MyRepo.insert()
+
+      %Post{title: "test"} = MyRepo.update!(post)
+    end
   end
 
   describe "insert_or_update/1" do
@@ -388,6 +406,18 @@ defmodule Mongo.RepoTest do
       assert Map.get(post, :_id) == Map.get(updated, :_id)
       assert updated.title == "updated"
     end
+
+    test "updates a document without changes if it does already exist" do
+      {:ok, post} =
+        Post.new()
+        |> Map.put(:title, "test")
+        |> MyRepo.insert_or_update()
+
+      {:ok, updated} = MyRepo.insert_or_update(post)
+
+      assert Map.get(post, :_id) == Map.get(updated, :_id)
+      assert updated.title == "test"
+    end
   end
 
   describe "insert_or_update!/1" do
@@ -414,6 +444,18 @@ defmodule Mongo.RepoTest do
       assert Map.get(post, :_id) == Map.get(updated, :_id)
       assert updated.title == "updated"
     end
+
+    test "updates a document without changes if it does already exist" do
+      post =
+        Post.new()
+        |> Map.put(:title, "test")
+        |> MyRepo.insert_or_update!()
+
+      updated = MyRepo.insert_or_update!(post)
+
+      assert Map.get(post, :_id) == Map.get(updated, :_id)
+      assert updated.title == "test"
+    end
   end
 
   describe "delete/2" do