#106: work in progress: fixing unit tests

Author: zookzook

insights/assets/css/app.css

@@ -39,6 +39,10 @@
   background-color: #cbe2fc;
 }
 
+a.list-group-item.selected {
+  font-weight: bold;
+}
+
 .separator {
   height: 5px;
   background-color: rgba(0, 0, 0, 0.125) !important;

insights/lib/insights/event_handler.ex

@@ -25,11 +25,15 @@ defmodule Insights.EventHandler do
   end
 
   def handle_info({:broadcast, :topology, event}, state) do
-    ## info("Receiving topology event: #{inspect event}")
     Phoenix.PubSub.local_broadcast(Insights.PubSub, "topology", event)
     {:noreply, state}
   end
 
+  def handle_info({:broadcast, :commands, event}, state) do
+    Phoenix.PubSub.local_broadcast(Insights.PubSub, "commands", event)
+    {:noreply, state}
+  end
+
   def handle_info(_message, state) do
     ## info("Receiving message: #{inspect message}")
     {:noreply, state}

insights/lib/insights/test.ex

@@ -0,0 +1,45 @@
+defmodule Insights.Test do
+
+  require Logger
+
+  @host_unreachable                     6
+  @host_not_found                       7
+  @network_timeout                      89
+  @shutdown_in_progress                 91
+  @primary_stepped_down                 189
+  @exceeded_time_limit                  262
+  @socket_exception                     9001
+  @not_master                           10107
+  @interrupted_at_shutdown              11600
+  @interrupted_due_to_repl_state_change 11602
+  @not_master_no_slaveok                13435
+  @not_master_or_secondary              13436
+  @stale_shard_version                  63
+  @stale_epoch                          150
+  #@stale_config                         13388
+  @retry_change_stream                  234
+  @failed_to_satisfy_read_preference    133
+
+  @resumxable [@host_unreachable, @host_not_found, @network_timeout, @shutdown_in_progress, @primary_stepped_down,
+    @exceeded_time_limit, @socket_exception, @not_master, @interrupted_at_shutdown, @interrupted_at_shutdown,
+    @interrupted_due_to_repl_state_change, @not_master_no_slaveok, @not_master_or_secondary, @stale_shard_version,
+    @stale_epoch, @retry_change_stream, @failed_to_satisfy_read_preference] #@stale_config,
+
+  @resumable [@primary_stepped_down ]
+  def test() do
+    @resumable
+    |> Enum.map(fn code ->
+
+      fail_cmd = [
+        configureFailPoint: "failCommand",
+        mode: %{times: 1},
+        data: [errorCode: code, failCommands: ["find"]]
+      ]
+
+      {:ok, _} = Mongo.admin_command(:mongo, fail_cmd)
+      {:error, msg} = Mongo.find_one(:mongo, "test", %{})
+      Logger.info("Error: #{inspect msg}")
+    end)
+  end
+end
+

insights/lib/insights_web/live/topology_live.ex

@@ -12,6 +12,7 @@ defmodule InsightsWeb.TopologyLive do
 
     if connected?(socket) do
       Phoenix.PubSub.subscribe(Insights.PubSub, "topology")
+      Phoenix.PubSub.subscribe(Insights.PubSub, "commands")
     end
 
     {:ok, reset_defaults(socket)}
@@ -23,16 +24,45 @@ defmodule InsightsWeb.TopologyLive do
   end
 
   @impl true
-  def handle_info(%Mongo.Events.ServerDescriptionChangedEvent{}, socket) do
-    {:noreply, reset_defaults(socket)}
-  end
+  def handle_info(%Mongo.Events.ServerDescriptionChangedEvent{} = event, %{assigns: %{events: events}} = socket) do
+
+    event = event
+            |> Map.put(:time_stamp, DateTime.utc_now())
+            |> Map.put(:id, random_string(10))
+    events = [event | events] |> Enum.take(10)
+    socket = socket
+             |> set_topology(Topology.get_state(:mongo))
+             |> assign(events: events)
 
-  def handle_info(_message, socket) do
     {:noreply, socket}
   end
 
+  def handle_info(event, %{assigns: %{events: events}} = socket) do
+    event = event
+            |> Map.put(:time_stamp, DateTime.utc_now())
+            |> Map.put(:id, random_string(10))
+    events = [event | events] |> Enum.take(10)
+    {:noreply, assign(socket, events: events)}
+  end
+
+  def handle_event("show-events", _params, socket) do
+    {:noreply, assign(socket, tab: "events")}
+  end
+
+  def handle_event("show-details", _params, socket) do
+    {:noreply, assign(socket, tab: "details")}
+  end
+
+  def handle_event("select-event", %{"id" => event_id}, %{assigns: %{events: events}} = socket) do
+    {:noreply, assign(socket, event: Enum.find(events, fn %{id: id} -> event_id == id end))}
+  end
+
   defp reset_defaults(socket) do
-    set_topology(socket, Topology.get_state(:mongo))
+    socket
+    |> set_topology(Topology.get_state(:mongo))
+    |> assign(events: [])
+    |> assign(tab: "details")
+    |> assign(event: nil)
   end
 
   def set_topology(socket, %{topology: %{servers: servers} = topology, monitors: monitors}) do
@@ -54,5 +84,9 @@ defmodule InsightsWeb.TopologyLive do
     |> assign(monitors: [])
   end
 
+  def random_string(length) do
+    :crypto.strong_rand_bytes(length) |> Base.url_encode64 |> binary_part(0, length)
+  end
+
 
 end

insights/lib/insights_web/templates/topology/details.html.heex

@@ -0,0 +1,31 @@
+<div class="row">
+    <div class="col-6">
+        <%= if @topology do %>
+        <ul class="list-group stripes">
+            <li class="list-group-item d-flex justify-content-between"><label>Type:</label><%= @topology.type%></li>
+            <li class="list-group-item d-flex justify-content-between"><label>Heartbeat frequency ms:</label><%= @topology.heartbeat_frequency_ms%></li>
+            <li class="list-group-item d-flex justify-content-between"><label>Local threshold ms:</label><%= @topology.local_threshold_ms%></li>
+            <li class="list-group-item d-flex justify-content-between"><label>Compatible:</label><%= @topology.compatible%></li>
+        </ul>
+        <% else %>
+        <div class="alert alert-warning">
+            <p>No topology entry found!</p>
+        </div>
+        <% end %>
+    </div>
+</div>
+<div class="row mt-3">
+    <div class="col-12">
+        <h2 class="mt-3">Servers</h2>
+        <%= for server <- @servers do %>
+        <div class="row mt-3">
+            <div class="col-6">
+                <%= render InsightsWeb.TopologyView, "server.html", server: server %>
+            </div>
+            <div class="col-6">
+                <%= render InsightsWeb.TopologyView, "monitor.html", monitor: Map.get(@monitors, server.address) %>
+            </div>
+        </div>
+        <% end %>
+    </div>
+</div>

insights/lib/insights_web/templates/topology/event.html.heex

@@ -0,0 +1 @@
+<a href="javascript:void(0);" phx-click="select-event" phx-value-id={@event.id} class={"list-group-item d-flex justify-content-between #{event_selected?(@event.id == @select_event_id)}"}><label><%= @event.time_stamp%>:</label><%= event_name(@event)%></a>

insights/lib/insights_web/templates/topology/events.html.heex

@@ -0,0 +1,24 @@
+<div class="row">
+    <div class="col-8">
+        <div class="list-group stripes">
+            <%= for event <- @events do %>
+            <%= if @event do %>
+            <%= render InsightsWeb.TopologyView, "event.html", event: event, select_event_id: @event.id %>
+            <% else %>
+            <%= render InsightsWeb.TopologyView, "event.html", event: event, select_event_id: nil %>
+            <% end %>
+            <% end %>
+        </div>
+    </div>
+</div>
+
+<%= if @event do %>
+<h5 class="mt-3"><%= event_name(@event)%></h5>
+<div class="row mt-3">
+    <div class="col-8">
+        <ul class="list-group stripes">
+            <li class="list-group-item d-flex justify-content-between"><label>Timestamp:</label><%= @event.time_stamp%></li>
+        </ul>
+    </div>
+</div>
+<% end %>

insights/lib/insights_web/templates/topology/index.html.heex

@@ -1,35 +1,21 @@
 <div class="container mt-5">
     <h1>Topology</h1>
 
-    <div class="row">
-        <div class="col-6">
-            <%= if @topology do %>
-            <ul class="list-group stripes">
-                <li class="list-group-item d-flex justify-content-between"><label>Type:</label><%= @topology.type%></li>
-                <li class="list-group-item d-flex justify-content-between"><label>Heartbeat frequency ms:</label><%= @topology.heartbeat_frequency_ms%></li>
-                <li class="list-group-item d-flex justify-content-between"><label>Local threshold ms:</label><%= @topology.local_threshold_ms%></li>
-                <li class="list-group-item d-flex justify-content-between"><label>Compatible:</label><%= @topology.compatible%></li>
-            </ul>
-            <% else %>
-            <div class="alert alert-warning">
-                <p>No topology entry found!</p>
-            </div>
-            <% end %>
+    <ul class="nav nav-tabs">
+        <li class="nav-item">
+            <a class={"nav-link #{tab_active("details", @tab)}"} phx-click="show-details" href="javascript:void(0);">Details</a>
+        </li>
+        <li class="nav-item">
+            <a class={"nav-link #{tab_active("events", @tab)}"} phx-click="show-events" href="javascript:void(0);">Events</a>
+        </li>
+    </ul>
+    <div class="tab-content pt-3 bg-white p-3 border-bottom border-end border-start">
+        <div class={"tab-pane fade show #{tab_active("details", @tab)}"} id="details">
+            <%= render InsightsWeb.TopologyView, "details.html", assigns %>
         </div>
-    </div>
-    <div class="row mt-3">
-        <div class="col-12">
-            <h2 class="mt-3">Servers</h2>
-            <%= for server <- @servers do %>
-            <div class="row mt-3">
-                <div class="col-6">
-                    <%= render InsightsWeb.TopologyView, "server.html", server: server %>
-                </div>
-                <div class="col-6">
-                    <%= render InsightsWeb.TopologyView, "monitor.html", monitor: Map.get(@monitors, server.address) %>
-                </div>
-            </div>
-            <% end %>
+        <div class={"tab-pane fade show #{tab_active("events", @tab)}"} id="events">
+            <%= render InsightsWeb.TopologyView, "events.html", assigns %>
         </div>
     </div>
+
 </div>

insights/lib/insights_web/views/topology_view.ex

@@ -1,3 +1,27 @@
 defmodule InsightsWeb.TopologyView do
   use InsightsWeb, :view
+
+  def event_name(%{__struct__: name} = struct) do
+    name
+    |> Module.split
+    |> Enum.join(".")
+  end
+
+  @doc """
+  Support for tabs
+  """
+  def tab_active(tab, current) do
+    case tab == current do
+      true -> "active"
+      false -> []
+    end
+  end
+
+  def event_selected?(true) do
+    "selected"
+  end
+
+  def event_selected?(_) do
+    []
+  end
 end

lib/mongo.ex

@@ -69,8 +69,6 @@ defmodule Mongo do
   # 5000
   @timeout 15000
 
-  @dialyzer [no_match: [count_documents!: 4]]
-
   @type conn :: DbConnection.Conn
   @type collection :: String.t()
   @opaque cursor :: Mongo.Cursor.t()
@@ -805,19 +803,12 @@ defmodule Mongo do
   def exec_command_session(session, cmd, opts) do
     with {:ok, conn, new_cmd} <- Session.bind_session(session, cmd),
          {:ok, _cmd, response} <- DBConnection.execute(conn, %Query{action: :command}, [new_cmd], defaults(opts)),
-         doc <- Session.update_session(session, response, opts), ## todo
-         {:ok, _flags, doc} <- check_for_error(response) do
+         :ok <- Session.update_session(session, response, opts),
+         {:ok, {_flags, doc}} <- check_for_error(response) do
       {:ok, doc}
     else
       {:error, error} ->
-        case Error.not_writable_primary_or_recovering?(error, opts) do
-          true ->
-            Session.mark_server_unknown(session)
-            {:error, error}
-
-          false ->
-            {:error, error}
-        end
+        {:error, error}
     end
   end
 
@@ -853,8 +844,6 @@ defmodule Mongo do
   end
 
   defp check_for_error({doc, event, _flags, duration}) do
-
-    Logger.info("Checking Error: #{inspect doc}")
     error = Mongo.Error.exception(doc)
 
     Events.notify(
@@ -996,8 +985,7 @@ defmodule Mongo do
     with {:ok, doc} <- issue_command(topology_pid, cmd, :write, opts) do
       case doc do
         %{"writeErrors" => _} ->
-          {:error,
-           %Mongo.WriteError{n: doc["n"], ok: doc["ok"], write_errors: doc["writeErrors"]}}
+          {:error, %Mongo.WriteError{n: doc["n"], ok: doc["ok"], write_errors: doc["writeErrors"]}}
 
         _ ->
           case acknowledged?(write_concern) do
@@ -1480,13 +1468,7 @@ defmodule Mongo do
   ##
   # Checks the validity of the document structure. that means either you use binaries or atoms as a key, but not in combination of both.
   #
-  # todo support for structs
   defp normalize_doc(doc) do
-    # doc = case Map.has_key?(doc, :__struct__) do
-    #  true  -> Map.to_list(doc)
-    #  false -> doc
-    # end
-
     Enum.reduce(doc, {:unknown, []}, fn
       {key, _value}, {:binary, _acc} when is_atom(key) -> invalid_doc(doc)
       {key, _value}, {:atom, _acc} when is_binary(key) -> invalid_doc(doc)