Align checkNotifications response on Android (#829)

Author: zoontek

README.md

@@ -772,6 +772,8 @@ request(PERMISSIONS.IOS.LOCATION_ALWAYS).then((result) => {
 
 Check notifications permission status and get notifications settings values.
 
+_⚠️  Android will never return `blocked` after a `checkNotifications`, you have to request the permission to get the info._
+
 ```ts
 type NotificationSettings = {
   // properties only available on iOS

android/src/main/java/com/zoontek/rnpermissions/RNPermissionsModule.java

@@ -67,18 +67,28 @@ private boolean isPermissionUnavailable(@NonNull final String permission) {
     }
   }
 
-  @ReactMethod
-  public void checkNotifications(final Promise promise) {
+  // Only used on Android < 13 (the POST_NOTIFICATIONS runtime permission isn't available)
+  private WritableMap getLegacyNotificationsResponse(String disabledStatus) {
     final boolean enabled = NotificationManagerCompat
       .from(getReactApplicationContext()).areNotificationsEnabled();
 
     final WritableMap output = Arguments.createMap();
     final WritableMap settings = Arguments.createMap();
 
-    output.putString("status", enabled ? GRANTED : BLOCKED);
+    output.putString("status", enabled ? GRANTED : disabledStatus);
     output.putMap("settings", settings);
 
-    promise.resolve(output);
+    return output;
+  }
+
+  @ReactMethod
+  public void checkNotifications(final Promise promise) {
+    promise.resolve(getLegacyNotificationsResponse(DENIED));
+  }
+
+  @Override
+  public void requestNotifications(final ReadableArray options, final Promise promise) {
+    promise.resolve(getLegacyNotificationsResponse(BLOCKED));
   }
 
   @ReactMethod
@@ -304,11 +314,6 @@ public void requestLocationAccuracy(String purposeKey, Promise promise) {
     promise.reject("Permissions:requestLocationAccuracy", "requestLocationAccuracy is not supported on Android");
   }
 
-  @Override
-  public void requestNotifications(ReadableArray options, Promise promise) {
-    promise.reject("Permissions:requestNotifications", "requestNotifications is not supported on Android");
-  }
-
   @Override
   public void openPhotoPicker(Promise promise) {
     promise.reject("Permissions:openPhotoPicker", "openPhotoPicker is not supported on Android");

android/src/paper/java/com/zoontek/rnpermissions/NativePermissionsModuleSpec.java

@@ -42,6 +42,10 @@ public NativePermissionsModuleSpec(ReactApplicationContext reactContext) {
   @DoNotStrip
   public abstract void checkNotifications(Promise promise);
 
+  @ReactMethod
+  @DoNotStrip
+  public abstract void requestNotifications(ReadableArray options, Promise promise);
+
   @ReactMethod
   @DoNotStrip
   public abstract void check(String permission, Promise promise);
@@ -70,10 +74,6 @@ public NativePermissionsModuleSpec(ReactApplicationContext reactContext) {
   @DoNotStrip
   public abstract void requestLocationAccuracy(String purposeKey, Promise promise);
 
-  @ReactMethod
-  @DoNotStrip
-  public abstract void requestNotifications(ReadableArray options, Promise promise);
-
   @ReactMethod
   @DoNotStrip
   public abstract void openPhotoPicker(Promise promise);

example/android/app/build.gradle

@@ -1,4 +1,5 @@
 apply plugin: "com.android.application"
+apply plugin: "org.jetbrains.kotlin.android"
 apply plugin: "com.facebook.react"
 
 /**
@@ -70,8 +71,8 @@ def jscFlavor = 'org.webkit:android-jsc:+'
 
 android {
     ndkVersion rootProject.ext.ndkVersion
-
-    compileSdkVersion rootProject.ext.compileSdkVersion
+    buildToolsVersion rootProject.ext.buildToolsVersion
+    compileSdk rootProject.ext.compileSdkVersion
 
     namespace "com.rnpermissionsexample"
     defaultConfig {
@@ -106,13 +107,8 @@ android {
 dependencies {
     // The version of react-native is set by the React Native Gradle Plugin
     implementation("com.facebook.react:react-android")
+    implementation("com.facebook.react:flipper-integration")
 
-    debugImplementation("com.facebook.flipper:flipper:${FLIPPER_VERSION}")
-    debugImplementation("com.facebook.flipper:flipper-network-plugin:${FLIPPER_VERSION}") {
-        exclude group:'com.squareup.okhttp3', module:'okhttp'
-    }
-
-    debugImplementation("com.facebook.flipper:flipper-fresco-plugin:${FLIPPER_VERSION}")
     if (hermesEnabled.toBoolean()) {
         implementation("com.facebook.react:hermes-android")
     } else {

example/android/app/src/debug/AndroidManifest.xml

@@ -2,12 +2,8 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools">
 
-    <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>
-
     <application
         android:usesCleartextTraffic="true"
         tools:targetApi="28"
-        tools:ignore="GoogleAppIndexingWarning">
-        <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" android:exported="false" />
-    </application>
+        tools:ignore="GoogleAppIndexingWarning"/>
 </manifest>

example/android/app/src/debug/java/com/rnpermissionsexample/ReactNativeFlipper.java

@@ -0,0 +1,22 @@
+package com.rnpermissionsexample
+
+import com.facebook.react.ReactActivity
+import com.facebook.react.ReactActivityDelegate
+import com.facebook.react.defaults.DefaultNewArchitectureEntryPoint.fabricEnabled
+import com.facebook.react.defaults.DefaultReactActivityDelegate
+
+class MainActivity : ReactActivity() {
+
+  /**
+   * Returns the name of the main component registered from JavaScript. This is used to schedule
+   * rendering of the component.
+   */
+  override fun getMainComponentName(): String = "RNPermissionsExample"
+
+  /**
+   * Returns the instance of the [ReactActivityDelegate]. We use [DefaultReactActivityDelegate]
+   * which allows you to enable New Architecture with a single boolean flags [fabricEnabled]
+   */
+  override fun createReactActivityDelegate(): ReactActivityDelegate =
+      DefaultReactActivityDelegate(this, mainComponentName, fabricEnabled)
+}

example/android/app/src/main/java/com/rnpermissionsexample/MainActivity.java

@@ -0,0 +1,45 @@
+package com.rnpermissionsexample
+
+import android.app.Application
+import com.facebook.react.PackageList
+import com.facebook.react.ReactApplication
+import com.facebook.react.ReactHost
+import com.facebook.react.ReactNativeHost
+import com.facebook.react.ReactPackage
+import com.facebook.react.defaults.DefaultNewArchitectureEntryPoint.load
+import com.facebook.react.defaults.DefaultReactHost.getDefaultReactHost
+import com.facebook.react.defaults.DefaultReactNativeHost
+import com.facebook.react.flipper.ReactNativeFlipper
+import com.facebook.soloader.SoLoader
+
+class MainApplication : Application(), ReactApplication {
+
+  override val reactNativeHost: ReactNativeHost =
+      object : DefaultReactNativeHost(this) {
+        override fun getPackages(): List<ReactPackage> {
+          // Packages that cannot be autolinked yet can be added manually here, for example:
+          // packages.add(new MyReactNativePackage());
+          return PackageList(this).packages
+        }
+
+        override fun getJSMainModuleName(): String = "index"
+
+        override fun getUseDeveloperSupport(): Boolean = BuildConfig.DEBUG
+
+        override val isNewArchEnabled: Boolean = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED
+        override val isHermesEnabled: Boolean = BuildConfig.IS_HERMES_ENABLED
+      }
+
+  override val reactHost: ReactHost
+    get() = getDefaultReactHost(this.applicationContext, reactNativeHost)
+
+  override fun onCreate() {
+    super.onCreate()
+    SoLoader.init(this, false)
+    if (BuildConfig.IS_NEW_ARCHITECTURE_ENABLED) {
+      // If you opted-in for the New Architecture, we load the native entry point for this app.
+      load()
+    }
+    ReactNativeFlipper.initializeFlipper(this, reactNativeHost.reactInstanceManager)
+  }
+}