feat: Do not use C speedups on Python 3.13+ freethreading #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-maurer
reviewed
Oct 19, 2024
Do not enable C speedups by default if running Python 3.13+ in freethreading mode (with GIL disabled). Since the extension does not support this mode explicitly at the moment, loading it would cause CPython to reenable GIL with a warning and penalize the whole environment. Discussed in issue zopefoundation#330.
mgorny
force-pushed
the
freethreading-no-speedups
branch
from
b3e4385 to
fda90bc
Compare
d-maurer
approved these changes
Oct 19, 2024
|
@tseaver @davisagli I thought that the refactoring of the C code was done to support free threading. Am I wrong here? |
|
@icemac That's my understanding too. I'll need to find some time to look more closely and see if we just need to declare now that we support it, or if more changes are also needed. |
|
|
My CLA has just been approved. Should this be merged then, or should I close it pending proper FT support? |
|
Michał Górny wrote at 2024-10-23 03:07 -0700:
My CLA has just been approved. Should this be merged then, or should I close it pending proper FT support?
I got the impression that Tres and David are interested in full FT support.
Maybe, it will be available soon.
I would say we delay the merging for some time waiting if FT support
will arive soon. If this should not happen, we can merge in a few weeks.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not enable C speedups by default if running Python 3.13+ in freethreading mode (with GIL disabled). Since the extension does not support this mode explicitly at the moment, loading it would cause CPython to reenable GIL with a warning and penalize the whole environment.
Discussed in issue #330.
I've signed the CLA today, but I suppose it will take some time for it to be processed.