Skip to content

Commit 21deedc

Browse files
committed
Improve OpenItemsController items observer registration
1 parent 7583ed1 commit 21deedc

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

Zotero/Controllers/OpenItemsController.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,7 @@ final class OpenItemsController {
177177
var existingItems = getItems(for: sessionIdentifier)
178178
if let index = existingItems.firstIndex(where: { $0.kind == kind }) {
179179
existingItems[index].lastOpened = .now
180+
// No need to call setItems, to register a new items observer, as only items metadata were updated.
180181
itemsBySessionIdentifier[sessionIdentifier] = existingItems
181182
DDLogInfo("OpenItemsController: already opened item \(kind) became most recent for \(sessionIdentifier)")
182183
observable(for: sessionIdentifier).on(.next(existingItems))
@@ -204,7 +205,8 @@ final class OpenItemsController {
204205
var itemsChanged: Bool = false
205206
defer {
206207
if itemsChanged {
207-
observable(for: sessionIdentifier).on(.next(existingItems))
208+
// setItems will produce next observable event
209+
setItems(existingItems, for: sessionIdentifier, validate: false)
208210
}
209211
}
210212
var item: Item?

0 commit comments

Comments
 (0)