Remove Todos for CSR checking

zhlhahaha · zhlhahaha · commit 006980c1607a · 2019-12-31T09:49:00.000+08:00
Remove Todos for verification of “allowed to
post CSR” and "allowed to auto approve CSR"
for bootstraptoken group, as these privilege
bindings are not managed by kubeadm source
code

Signed-off-by: Howard Zhang &lt;howard.zhang@arm.com&gt;
diff --git a/test/e2e_kubeadm/bootstrap_token_test.go b/test/e2e_kubeadm/bootstrap_token_test.go
@@ -68,7 +68,6 @@ var _ = Describe("bootstrap token", func() {
 			rbacv1.GroupKind, bootstrapTokensGroup,
 			bootstrapTokensAllowPostCSRClusterRoleName,
 		)
-		//TODO: check if possible to verify "allowed to post CSR" using subject asses review as well
 	})
 
 	ginkgo.It("should be allowed to auto approve CSR for kubelet certificates on joining nodes", func() {
@@ -77,6 +76,5 @@ var _ = Describe("bootstrap token", func() {
 			rbacv1.GroupKind, bootstrapTokensGroup,
 			bootstrapTokensCSRAutoApprovalClusterRoleName,
 		)
-		//TODO: check if possible to verify "allowed to auto approve CSR" using subject asses review as well
 	})
 })

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,6 @@ var _ = Describe("bootstrap token", func() {`
`68`	`68`	`rbacv1.GroupKind, bootstrapTokensGroup,`
`69`	`69`	`bootstrapTokensAllowPostCSRClusterRoleName,`
`70`	`70`	`)`
`71`		`- //TODO: check if possible to verify "allowed to post CSR" using subject asses review as well`
`72`	`71`	`})`
`73`	`72`
`74`	`73`	`ginkgo.It("should be allowed to auto approve CSR for kubelet certificates on joining nodes", func() {`
`@@ -77,6 +76,5 @@ var _ = Describe("bootstrap token", func() {`
`77`	`76`	`rbacv1.GroupKind, bootstrapTokensGroup,`
`78`	`77`	`bootstrapTokensCSRAutoApprovalClusterRoleName,`
`79`	`78`	`)`
`80`		`- //TODO: check if possible to verify "allowed to auto approve CSR" using subject asses review as well`
`81`	`79`	`})`
`82`	`80`	`})`