kubetestgen: improve errors handling

php-coder · web-flow · commit 02885845ff4d · 2020-01-06T15:21:54.000Z
- don't proceed when a file creation has been failed
- handle a possible error from WriteString()
diff --git a/test/conformance/kubetestgen/kubetestgen.go b/test/conformance/kubetestgen/kubetestgen.go
@@ -131,6 +131,7 @@ func printYAML(fileName string, areaO Area) {
 	f, err := os.Create(fileName + ".yaml")
 	if err != nil {
 		fmt.Printf("ERROR: %s\n", err.Error())
+		os.Exit(1)
 	}
 	defer f.Close()
 	y, err := yaml.Marshal(areaO)
@@ -139,7 +140,11 @@ func printYAML(fileName string, areaO Area) {
 		os.Exit(1)
 	}
 
-	f.WriteString(string(y))
+	_, err = f.WriteString(string(y))
+	if err != nil {
+		fmt.Printf("ERROR: %s\n", err.Error())
+		os.Exit(1)
+	}
 }
 
 func countFields(suites []Suite) {

Original file line number	Diff line number	Diff line change
`@@ -131,6 +131,7 @@ func printYAML(fileName string, areaO Area) {`
`131`	`131`	`f, err := os.Create(fileName + ".yaml")`
`132`	`132`	`if err != nil {`
`133`	`133`	`fmt.Printf("ERROR: %s\n", err.Error())`
	`134`	`+ os.Exit(1)`
`134`	`135`	`}`
`135`	`136`	`defer f.Close()`
`136`	`137`	`y, err := yaml.Marshal(areaO)`
`@@ -139,7 +140,11 @@ func printYAML(fileName string, areaO Area) {`
`139`	`140`	`os.Exit(1)`
`140`	`141`	`}`
`141`	`142`
`142`		`- f.WriteString(string(y))`
	`143`	`+ _, err = f.WriteString(string(y))`
	`144`	`+ if err != nil {`
	`145`	`+ fmt.Printf("ERROR: %s\n", err.Error())`
	`146`	`+ os.Exit(1)`
	`147`	`+ }`
`143`	`148`	`}`
`144`	`149`
`145`	`150`	`func countFields(suites []Suite) {`