Skip to content

Commit 0393b59

Browse files
authored
Merge pull request kubernetes#89950 from tanjunchen/fix-bug-20200408
/test/e2e/apimachinery/:fix bug
2 parents b3837f8 + bf170e1 commit 0393b59

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

test/e2e/apimachinery/aggregator.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,10 +274,12 @@ func TestSampleAPIServer(f *framework.Framework, aggrclient *aggregatorclient.Cl
274274
}
275275
deployment, err := client.AppsV1().Deployments(namespace).Create(context.TODO(), d, metav1.CreateOptions{})
276276
framework.ExpectNoError(err, "creating deployment %s in namespace %s", deploymentName, namespace)
277+
277278
err = e2edeployment.WaitForDeploymentRevisionAndImage(client, namespace, deploymentName, "1", image)
278279
framework.ExpectNoError(err, "waiting for the deployment of image %s in %s in %s to complete", image, deploymentName, namespace)
280+
279281
err = e2edeployment.WaitForDeploymentRevisionAndImage(client, namespace, deploymentName, "1", etcdImage)
280-
framework.ExpectNoError(err, "waiting for the deployment of image %s in %s to complete", etcdImage, deploymentName, namespace)
282+
framework.ExpectNoError(err, "waiting for the deployment of image %s in %s in %s to complete", etcdImage, deploymentName, namespace)
281283

282284
// kubectl create -f service.yaml
283285
serviceLabels := map[string]string{"apiserver": "true"}

test/e2e/apimachinery/crd_conversion_webhook.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -338,11 +338,14 @@ func deployCustomResourceWebhookAndService(f *framework.Framework, image string,
338338
}
339339
deployment, err := client.AppsV1().Deployments(namespace).Create(context.TODO(), d, metav1.CreateOptions{})
340340
framework.ExpectNoError(err, "creating deployment %s in namespace %s", deploymentCRDName, namespace)
341+
341342
ginkgo.By("Wait for the deployment to be ready")
343+
342344
err = e2edeployment.WaitForDeploymentRevisionAndImage(client, namespace, deploymentCRDName, "1", image)
343-
framework.ExpectNoError(err, "waiting for the deployment of image %s in %s in %s to complete", image, deploymentName, namespace)
345+
framework.ExpectNoError(err, "waiting for the deployment of image %s in %s in %s to complete", image, deploymentCRDName, namespace)
346+
344347
err = e2edeployment.WaitForDeploymentComplete(client, deployment)
345-
framework.ExpectNoError(err, "waiting for the deployment status valid", image, deploymentCRDName, namespace)
348+
framework.ExpectNoError(err, "waiting for %s deployment status valid", deploymentCRDName)
346349

347350
ginkgo.By("Deploying the webhook service")
348351

0 commit comments

Comments
 (0)