Skip to content

Commit 03e90b8

Browse files
authored
Merge pull request kubernetes#86167 from yiyang5055/change-CounterVec-to-Counter
change CounterVec to use Counter in the Kubelet's Pod Lifecycle Event…
2 parents 9f841bf + 0f410d6 commit 03e90b8

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

pkg/kubelet/metrics/metrics.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -165,17 +165,16 @@ var (
165165
StabilityLevel: metrics.ALPHA,
166166
},
167167
)
168-
// PLEGDiscardEvents is a Histogram that tracks the duration (in seconds) it takes for discarding events in the Kubelet's
169-
// Pod Lifecycle Event Generator (PLEG).
170-
PLEGDiscardEvents = metrics.NewCounterVec(
168+
// PLEGDiscardEvents is a Counter that tracks the number of discarding events in the Kubelet's Pod Lifecycle Event Generator (PLEG).
169+
PLEGDiscardEvents = metrics.NewCounter(
171170
&metrics.CounterOpts{
172171
Subsystem: KubeletSubsystem,
173172
Name: PLEGDiscardEventsKey,
174173
Help: "The number of discard events in PLEG.",
175174
StabilityLevel: metrics.ALPHA,
176175
},
177-
[]string{},
178176
)
177+
179178
// PLEGRelistInterval is a Histogram that tracks the intervals (in seconds) between relisting in the Kubelet's
180179
// Pod Lifecycle Event Generator (PLEG).
181180
PLEGRelistInterval = metrics.NewHistogram(

pkg/kubelet/pleg/generic.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ func (g *GenericPLEG) relist() {
272272
select {
273273
case g.eventChannel <- events[i]:
274274
default:
275-
metrics.PLEGDiscardEvents.WithLabelValues().Inc()
275+
metrics.PLEGDiscardEvents.Inc()
276276
klog.Error("event channel is full, discard this relist() cycle event")
277277
}
278278
}

0 commit comments

Comments
 (0)