Skip to content

Commit 046ac51

Browse files
authored
Merge pull request kubernetes#92720 from neolit123/1.19-add-kcm-port
kubeadm: add --port=0 for kube-controller-manager and kube-scheduler
2 parents b6cbe1b + f66513d commit 046ac51

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

cmd/kubeadm/app/phases/controlplane/manifests.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -332,6 +332,7 @@ func getControllerManagerCommand(cfg *kubeadmapi.ClusterConfiguration) []string
332332
caFile := filepath.Join(cfg.CertificatesDir, kubeadmconstants.CACertName)
333333

334334
defaultArguments := map[string]string{
335+
"port": "0",
335336
"bind-address": "127.0.0.1",
336337
"leader-elect": "true",
337338
"kubeconfig": kubeconfigFile,
@@ -402,6 +403,7 @@ func getControllerManagerCommand(cfg *kubeadmapi.ClusterConfiguration) []string
402403
func getSchedulerCommand(cfg *kubeadmapi.ClusterConfiguration) []string {
403404
kubeconfigFile := filepath.Join(kubeadmconstants.KubernetesDir, kubeadmconstants.SchedulerKubeConfigFileName)
404405
defaultArguments := map[string]string{
406+
"port": "0",
405407
"bind-address": "127.0.0.1",
406408
"leader-elect": "true",
407409
"kubeconfig": kubeconfigFile,

cmd/kubeadm/app/phases/controlplane/manifests_test.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -634,6 +634,7 @@ func TestGetControllerManagerCommand(t *testing.T) {
634634
},
635635
expected: []string{
636636
"kube-controller-manager",
637+
"--port=0",
637638
"--bind-address=127.0.0.1",
638639
"--leader-elect=true",
639640
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
@@ -658,6 +659,7 @@ func TestGetControllerManagerCommand(t *testing.T) {
658659
},
659660
expected: []string{
660661
"kube-controller-manager",
662+
"--port=0",
661663
"--bind-address=127.0.0.1",
662664
"--leader-elect=true",
663665
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
@@ -682,6 +684,7 @@ func TestGetControllerManagerCommand(t *testing.T) {
682684
},
683685
expected: []string{
684686
"kube-controller-manager",
687+
"--port=0",
685688
"--bind-address=127.0.0.1",
686689
"--leader-elect=true",
687690
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
@@ -711,6 +714,7 @@ func TestGetControllerManagerCommand(t *testing.T) {
711714
},
712715
expected: []string{
713716
"kube-controller-manager",
717+
"--port=0",
714718
"--bind-address=127.0.0.1",
715719
"--leader-elect=true",
716720
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
@@ -742,6 +746,7 @@ func TestGetControllerManagerCommand(t *testing.T) {
742746
},
743747
expected: []string{
744748
"kube-controller-manager",
749+
"--port=0",
745750
"--bind-address=127.0.0.1",
746751
"--leader-elect=true",
747752
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
@@ -772,6 +777,7 @@ func TestGetControllerManagerCommand(t *testing.T) {
772777
},
773778
expected: []string{
774779
"kube-controller-manager",
780+
"--port=0",
775781
"--bind-address=127.0.0.1",
776782
"--leader-elect=true",
777783
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
@@ -804,6 +810,7 @@ func TestGetControllerManagerCommand(t *testing.T) {
804810
},
805811
expected: []string{
806812
"kube-controller-manager",
813+
"--port=0",
807814
"--bind-address=127.0.0.1",
808815
"--leader-elect=true",
809816
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
@@ -838,6 +845,7 @@ func TestGetControllerManagerCommand(t *testing.T) {
838845
},
839846
expected: []string{
840847
"kube-controller-manager",
848+
"--port=0",
841849
"--bind-address=127.0.0.1",
842850
"--leader-elect=true",
843851
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
@@ -987,6 +995,7 @@ func TestGetControllerManagerCommandExternalCA(t *testing.T) {
987995
expectedArgFunc: func(tmpdir string) []string {
988996
return []string{
989997
"kube-controller-manager",
998+
"--port=0",
990999
"--bind-address=127.0.0.1",
9911000
"--leader-elect=true",
9921001
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
@@ -1016,6 +1025,7 @@ func TestGetControllerManagerCommandExternalCA(t *testing.T) {
10161025
expectedArgFunc: func(tmpdir string) []string {
10171026
return []string{
10181027
"kube-controller-manager",
1028+
"--port=0",
10191029
"--bind-address=127.0.0.1",
10201030
"--leader-elect=true",
10211031
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
@@ -1077,6 +1087,7 @@ func TestGetSchedulerCommand(t *testing.T) {
10771087
cfg: &kubeadmapi.ClusterConfiguration{},
10781088
expected: []string{
10791089
"kube-scheduler",
1090+
"--port=0",
10801091
"--bind-address=127.0.0.1",
10811092
"--leader-elect=true",
10821093
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/scheduler.conf",

0 commit comments

Comments
 (0)