Skip to content

Commit 05b3e89

Browse files
authored
Merge pull request kubernetes#95166 from vishsangale/master-to-control-plane-test-e2e-GetMasterHost
Updated symbol 'framework.GetMasterHost' to not use word 'master'
2 parents cc68a78 + 395a6d8 commit 05b3e89

File tree

12 files changed

+27
-27
lines changed

12 files changed

+27
-27
lines changed

test/e2e/apimachinery/etcd_failure.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ func doEtcdFailure(failCommand, fixCommand string) {
9999
}
100100

101101
func masterExec(cmd string) {
102-
host := framework.GetMasterHost() + ":22"
102+
host := framework.APIAddress() + ":22"
103103
result, err := e2essh.SSH(cmd, host, framework.TestContext.Provider)
104104
framework.ExpectNoError(err, "failed to SSH to host %s on provider %s and run command: %q", host, framework.TestContext.Provider, cmd)
105105
if result.Code != 0 {

test/e2e/apps/daemon_restart.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ var _ = SIGDescribe("DaemonRestart [Disruptive]", func() {
263263
// Requires master ssh access.
264264
e2eskipper.SkipUnlessProviderIs("gce", "aws")
265265
restarter := NewRestartConfig(
266-
framework.GetMasterHost(), "kube-controller", ports.InsecureKubeControllerManagerPort, restartPollInterval, restartTimeout)
266+
framework.APIAddress(), "kube-controller", ports.InsecureKubeControllerManagerPort, restartPollInterval, restartTimeout)
267267
restarter.restart()
268268

269269
// The intent is to ensure the replication controller manager has observed and reported status of
@@ -294,7 +294,7 @@ var _ = SIGDescribe("DaemonRestart [Disruptive]", func() {
294294
// Requires master ssh access.
295295
e2eskipper.SkipUnlessProviderIs("gce", "aws")
296296
restarter := NewRestartConfig(
297-
framework.GetMasterHost(), "kube-scheduler", kubeschedulerconfig.DefaultInsecureSchedulerPort, restartPollInterval, restartTimeout)
297+
framework.APIAddress(), "kube-scheduler", kubeschedulerconfig.DefaultInsecureSchedulerPort, restartPollInterval, restartTimeout)
298298

299299
// Create pods while the scheduler is down and make sure the scheduler picks them up by
300300
// scaling the rc to the same size.

test/e2e/cloud/gcp/addon_update.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -449,7 +449,7 @@ func getMasterSSHClient() (*ssh.Client, error) {
449449
HostKeyCallback: ssh.InsecureIgnoreHostKey(),
450450
}
451451

452-
host := framework.GetMasterHost() + ":22"
452+
host := framework.APIAddress() + ":22"
453453
client, err := ssh.Dial("tcp", host, config)
454454
if err != nil {
455455
return nil, fmt.Errorf("error getting SSH client to host %s: '%v'", host, err)

test/e2e/cloud/gcp/cluster_upgrade.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -585,7 +585,7 @@ func traceRouteToMaster() {
585585
framework.Logf("Could not find traceroute program")
586586
return
587587
}
588-
cmd := exec.Command(traceroute, "-I", framework.GetMasterHost())
588+
cmd := exec.Command(traceroute, "-I", framework.APIAddress())
589589
out, err := cmd.Output()
590590
if len(out) != 0 {
591591
framework.Logf(string(out))

test/e2e/framework/kubesystem/kubesystem.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ func RestartControllerManager() error {
3737
}
3838
cmd := "pidof kube-controller-manager | xargs sudo kill"
3939
framework.Logf("Restarting controller-manager via ssh, running: %v", cmd)
40-
result, err := e2essh.SSH(cmd, net.JoinHostPort(framework.GetMasterHost(), e2essh.SSHPort), framework.TestContext.Provider)
40+
result, err := e2essh.SSH(cmd, net.JoinHostPort(framework.APIAddress(), e2essh.SSHPort), framework.TestContext.Provider)
4141
if err != nil || result.Code != 0 {
4242
e2essh.LogResult(result)
4343
return fmt.Errorf("couldn't restart controller-manager: %v", err)
@@ -49,7 +49,7 @@ func RestartControllerManager() error {
4949
func WaitForControllerManagerUp() error {
5050
cmd := "curl http://localhost:" + strconv.Itoa(framework.InsecureKubeControllerManagerPort) + "/healthz"
5151
for start := time.Now(); time.Since(start) < time.Minute; time.Sleep(5 * time.Second) {
52-
result, err := e2essh.SSH(cmd, net.JoinHostPort(framework.GetMasterHost(), e2essh.SSHPort), framework.TestContext.Provider)
52+
result, err := e2essh.SSH(cmd, net.JoinHostPort(framework.APIAddress(), e2essh.SSHPort), framework.TestContext.Provider)
5353
if err != nil || result.Code != 0 {
5454
e2essh.LogResult(result)
5555
}

test/e2e/framework/log_size_monitoring.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,16 +159,16 @@ func (d *LogsSizeData) addNewData(ip, path string, timestamp time.Time, size int
159159
func NewLogsVerifier(c clientset.Interface, stopChannel chan bool) *LogsSizeVerifier {
160160
nodeAddresses, err := e2essh.NodeSSHHosts(c)
161161
ExpectNoError(err)
162-
masterAddress := GetMasterHost() + ":22"
162+
instanceAddress := APIAddress() + ":22"
163163

164164
workChannel := make(chan WorkItem, len(nodeAddresses)+1)
165165
workers := make([]*LogSizeGatherer, workersNo)
166166

167167
verifier := &LogsSizeVerifier{
168168
client: c,
169169
stopChannel: stopChannel,
170-
data: prepareData(masterAddress, nodeAddresses),
171-
masterAddress: masterAddress,
170+
data: prepareData(instanceAddress, nodeAddresses),
171+
masterAddress: instanceAddress,
172172
nodeAddresses: nodeAddresses,
173173
wg: sync.WaitGroup{},
174174
workChannel: workChannel,

test/e2e/framework/resource_usage_gatherer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,7 @@ type kubemarkResourceUsage struct {
604604
}
605605

606606
func getMasterUsageByPrefix(prefix string) (string, error) {
607-
sshResult, err := e2essh.SSH(fmt.Sprintf("ps ax -o %%cpu,rss,command | tail -n +2 | grep %v | sed 's/\\s+/ /g'", prefix), GetMasterHost()+":22", TestContext.Provider)
607+
sshResult, err := e2essh.SSH(fmt.Sprintf("ps ax -o %%cpu,rss,command | tail -n +2 | grep %v | sed 's/\\s+/ /g'", prefix), APIAddress()+":22", TestContext.Provider)
608608
if err != nil {
609609
return "", err
610610
}

test/e2e/framework/util.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -166,11 +166,11 @@ var RunID = uuid.NewUUID()
166166
// CreateTestingNSFn is a func that is responsible for creating namespace used for executing e2e tests.
167167
type CreateTestingNSFn func(baseName string, c clientset.Interface, labels map[string]string) (*v1.Namespace, error)
168168

169-
// GetMasterHost returns a hostname of a master.
170-
func GetMasterHost() string {
171-
masterURL, err := url.Parse(TestContext.Host)
169+
// APIAddress returns a address of an instance.
170+
func APIAddress() string {
171+
instanceURL, err := url.Parse(TestContext.Host)
172172
ExpectNoError(err)
173-
return masterURL.Hostname()
173+
return instanceURL.Hostname()
174174
}
175175

176176
// ProviderIs returns true if the provider is included is the providers. Otherwise false.

test/e2e/network/service.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3769,7 +3769,7 @@ func sshRestartMaster() error {
37693769
command = "sudo /etc/init.d/kube-apiserver restart"
37703770
}
37713771
framework.Logf("Restarting master via ssh, running: %v", command)
3772-
result, err := e2essh.SSH(command, net.JoinHostPort(framework.GetMasterHost(), e2essh.SSHPort), framework.TestContext.Provider)
3772+
result, err := e2essh.SSH(command, net.JoinHostPort(framework.APIAddress(), e2essh.SSHPort), framework.TestContext.Provider)
37733773
if err != nil || result.Code != 0 {
37743774
e2essh.LogResult(result)
37753775
return fmt.Errorf("couldn't restart apiserver: %v", err)

test/e2e/storage/flexvolume.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ func installFlex(c clientset.Interface, node *v1.Node, vendor, driver, filePath
8181
host, err = e2enode.GetInternalIP(node)
8282
}
8383
} else {
84-
masterHostWithPort := framework.GetMasterHost()
85-
hostName := getHostFromHostPort(masterHostWithPort)
84+
instanceWithPort := framework.APIAddress()
85+
hostName := getHostFromHostPort(instanceWithPort)
8686
host = net.JoinHostPort(hostName, e2essh.SSHPort)
8787
}
8888

@@ -113,8 +113,8 @@ func uninstallFlex(c clientset.Interface, node *v1.Node, vendor, driver string)
113113
host, err = e2enode.GetInternalIP(node)
114114
}
115115
} else {
116-
masterHostWithPort := framework.GetMasterHost()
117-
hostName := getHostFromHostPort(masterHostWithPort)
116+
instanceWithPort := framework.APIAddress()
117+
hostName := getHostFromHostPort(instanceWithPort)
118118
host = net.JoinHostPort(hostName, e2essh.SSHPort)
119119
}
120120

0 commit comments

Comments
 (0)