Skip to content

Commit 062fe2e

Browse files
authored
Merge pull request kubernetes#95025 from knight42/fix/ingress-gce-e2e
fix: correct glbc ClusterRole
2 parents 769f047 + 91bd116 commit 062fe2e

File tree

1 file changed

+7
-3
lines changed
  • cluster/addons/rbac/cluster-loadbalancing/glbc

1 file changed

+7
-3
lines changed

cluster/addons/rbac/cluster-loadbalancing/glbc/roles.yaml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ rules:
3535
- apiGroups: ["extensions", "networking.k8s.io"]
3636
resources: ["ingresses"]
3737
verbs: ["get", "list", "watch"]
38-
# For now, GLBC annotates ingress resources with various state and statuses:
38+
# For now, GLBC annotates ingress resources with various state and statuses:
3939
# https://github.com/kubernetes/ingress-gce/blob/50d49b077d9ab4362a02fae05f94e433cd3f08dc/pkg/controller/controller.go#L579
4040
# TODO(rramkumar1): Remove unnecessary `update` permission once statuses are propagated through `ingresses/status`
4141
- apiGroups: ["extensions", "networking.k8s.io"]
@@ -44,12 +44,16 @@ rules:
4444
- apiGroups: ["extensions", "networking.k8s.io"]
4545
resources: ["ingresses/status"]
4646
verbs: ["update", "patch"]
47-
# GLBC ensures that the `cloud.google.com/backendconfigs` CRD exists in a desired state:
48-
# https://github.com/kubernetes/ingress-gce/blob/4918eb2f0f484f09ac9e5a975907a9b16ed2b344/cmd/glbc/main.go#L93
47+
# GLBC ensures that the `cloud.google.com/backendconfigs` and `networking.gke.io/servicenetworkendpointgroups` CRD exists in a desired state:
48+
# https://github.com/kubernetes/ingress-gce/blob/5c3fcb5845e74b92ea8bd52929b15fc5c9fa7970/cmd/glbc/main.go#L108
49+
# https://github.com/kubernetes/ingress-gce/blob/5c3fcb5845e74b92ea8bd52929b15fc5c9fa7970/cmd/glbc/main.go#L133
4950
# TODO(rramkumar1): https://github.com/kubernetes/ingress-gce/issues/744
5051
- apiGroups: ["apiextensions.k8s.io"]
5152
resources: ["customresourcedefinitions"]
5253
verbs: ["get", "list", "watch", "update", "create", "patch"]
5354
- apiGroups: ["cloud.google.com"]
5455
resources: ["backendconfigs"]
5556
verbs: ["get", "list", "watch", "update", "create", "patch"]
57+
- apiGroups: ["networking.gke.io"]
58+
resources: ["servicenetworkendpointgroups"]
59+
verbs: ["get", "list", "watch", "update", "create", "patch"]

0 commit comments

Comments
 (0)