Skip to content

Commit 0817af7

Browse files
committed
Remove the 'DisabledForLargeClusters' tags from ELB network tests.
We did some internal testing at Google and, with the recent improvements, we believe that it's safe to re-enable these LB tests for large clusters. Ref. kubernetes#56138
1 parent c1f1b1b commit 0817af7

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

test/e2e/network/service.go

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1151,8 +1151,7 @@ var _ = SIGDescribe("Services", func() {
11511151
framework.ExpectNoError(err)
11521152
})
11531153

1154-
// TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed.
1155-
ginkgo.It("should be able to change the type and ports of a service [Slow] [DisabledForLargeClusters]", func() {
1154+
ginkgo.It("should be able to change the type and ports of a service [Slow]", func() {
11561155
// requires cloud load-balancer support
11571156
e2eskipper.SkipUnlessProviderIs("gce", "gke", "aws")
11581157

@@ -2398,9 +2397,8 @@ var _ = SIGDescribe("Services", func() {
23982397
execAffinityTestForNonLBServiceWithTransition(f, cs, svc)
23992398
})
24002399

2401-
// TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed.
24022400
// [LinuxOnly]: Windows does not support session affinity.
2403-
ginkgo.It("should have session affinity work for LoadBalancer service with ESIPP on [Slow] [DisabledForLargeClusters] [LinuxOnly]", func() {
2401+
ginkgo.It("should have session affinity work for LoadBalancer service with ESIPP on [Slow] [LinuxOnly]", func() {
24042402
// L4 load balancer affinity `ClientIP` is not supported on AWS ELB.
24052403
e2eskipper.SkipIfProviderIs("aws")
24062404

@@ -2410,9 +2408,8 @@ var _ = SIGDescribe("Services", func() {
24102408
execAffinityTestForLBService(f, cs, svc)
24112409
})
24122410

2413-
// TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed.
24142411
// [LinuxOnly]: Windows does not support session affinity.
2415-
ginkgo.It("should be able to switch session affinity for LoadBalancer service with ESIPP on [Slow] [DisabledForLargeClusters] [LinuxOnly]", func() {
2412+
ginkgo.It("should be able to switch session affinity for LoadBalancer service with ESIPP on [Slow] [LinuxOnly]", func() {
24162413
// L4 load balancer affinity `ClientIP` is not supported on AWS ELB.
24172414
e2eskipper.SkipIfProviderIs("aws")
24182415

@@ -2422,9 +2419,8 @@ var _ = SIGDescribe("Services", func() {
24222419
execAffinityTestForLBServiceWithTransition(f, cs, svc)
24232420
})
24242421

2425-
// TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed.
24262422
// [LinuxOnly]: Windows does not support session affinity.
2427-
ginkgo.It("should have session affinity work for LoadBalancer service with ESIPP off [Slow] [DisabledForLargeClusters] [LinuxOnly]", func() {
2423+
ginkgo.It("should have session affinity work for LoadBalancer service with ESIPP off [Slow] [LinuxOnly]", func() {
24282424
// L4 load balancer affinity `ClientIP` is not supported on AWS ELB.
24292425
e2eskipper.SkipIfProviderIs("aws")
24302426

@@ -2434,9 +2430,8 @@ var _ = SIGDescribe("Services", func() {
24342430
execAffinityTestForLBService(f, cs, svc)
24352431
})
24362432

2437-
// TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed.
24382433
// [LinuxOnly]: Windows does not support session affinity.
2439-
ginkgo.It("should be able to switch session affinity for LoadBalancer service with ESIPP off [Slow] [DisabledForLargeClusters] [LinuxOnly]", func() {
2434+
ginkgo.It("should be able to switch session affinity for LoadBalancer service with ESIPP off [Slow] [LinuxOnly]", func() {
24402435
// L4 load balancer affinity `ClientIP` is not supported on AWS ELB.
24412436
e2eskipper.SkipIfProviderIs("aws")
24422437

@@ -2788,8 +2783,7 @@ var _ = SIGDescribe("Services", func() {
27882783
})
27892784
})
27902785

2791-
// TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed.
2792-
var _ = SIGDescribe("ESIPP [Slow] [DisabledForLargeClusters]", func() {
2786+
var _ = SIGDescribe("ESIPP [Slow]", func() {
27932787
f := framework.NewDefaultFramework("esipp")
27942788
var loadBalancerCreateTimeout time.Duration
27952789

0 commit comments

Comments
 (0)