Merge pull request kubernetes#82471 from yutedz/lru-cache-rw

k8s-ci-robot · web-flow · commit 08fce550680f · 2019-09-13T10:42:31.000-07:00
Add note on the role of BenchmarkSimpleCache
diff --git a/staging/src/k8s.io/apiserver/pkg/authentication/token/cache/cache_test.go b/staging/src/k8s.io/apiserver/pkg/authentication/token/cache/cache_test.go
@@ -32,6 +32,9 @@ func TestSimpleCache(t *testing.T) {
 	testCache(newSimpleCache(4096, clock.RealClock{}), t)
 }
 
+// Note: the performance profile of this benchmark may not match that in the production.
+// When making change to SimpleCache, run test with and without concurrency to better understand the impact.
+// This is a tool to test and measure high concurrency of the cache in isolation and not to the Kubernetes usage of the Cache.
 func BenchmarkSimpleCache(b *testing.B) {
 	benchmarkCache(newSimpleCache(4096, clock.RealClock{}), b)
 }

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,9 @@ func TestSimpleCache(t *testing.T) {`
`32`	`32`	`testCache(newSimpleCache(4096, clock.RealClock{}), t)`
`33`	`33`	`}`
`34`	`34`
	`35`	`+// Note: the performance profile of this benchmark may not match that in the production.`
	`36`	`+// When making change to SimpleCache, run test with and without concurrency to better understand the impact.`
	`37`	`+// This is a tool to test and measure high concurrency of the cache in isolation and not to the Kubernetes usage of the Cache.`
`35`	`38`	`func BenchmarkSimpleCache(b *testing.B) {`
`36`	`39`	`benchmarkCache(newSimpleCache(4096, clock.RealClock{}), b)`
`37`	`40`	`}`