Skip to content

Commit 0adbd69

Browse files
authored
Merge pull request kubernetes#76385 from sttts/sttts-kube-aggregator-openapi-fix-existing
kube-aggregator: update existing openapi spec info if pre-existing
2 parents df117c7 + 1f1a524 commit 0adbd69

File tree

1 file changed

+6
-5
lines changed
  • staging/src/k8s.io/kube-aggregator/pkg/controllers/openapi/aggregator

1 file changed

+6
-5
lines changed

staging/src/k8s.io/kube-aggregator/pkg/controllers/openapi/aggregator/aggregator.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -202,15 +202,16 @@ func (s *specAggregator) tryUpdatingServiceSpecs(specInfo *openAPISpecInfo) erro
202202
if specInfo == nil {
203203
return fmt.Errorf("invalid input: specInfo must be non-nil")
204204
}
205-
orgSpecInfo, exists := s.openAPISpecs[specInfo.apiService.Name]
205+
origSpecInfo, existedBefore := s.openAPISpecs[specInfo.apiService.Name]
206+
s.openAPISpecs[specInfo.apiService.Name] = specInfo
207+
206208
// Skip aggregation if OpenAPI spec didn't change
207-
if exists && orgSpecInfo != nil && orgSpecInfo.etag == specInfo.etag {
209+
if existedBefore && origSpecInfo != nil && origSpecInfo.etag == specInfo.etag {
208210
return nil
209211
}
210-
s.openAPISpecs[specInfo.apiService.Name] = specInfo
211212
if err := s.updateOpenAPISpec(); err != nil {
212-
if exists {
213-
s.openAPISpecs[specInfo.apiService.Name] = orgSpecInfo
213+
if existedBefore {
214+
s.openAPISpecs[specInfo.apiService.Name] = origSpecInfo
214215
} else {
215216
delete(s.openAPISpecs, specInfo.apiService.Name)
216217
}

0 commit comments

Comments
 (0)