Skip to content

Commit 0c2827c

Browse files
committed
e2e: topomgr: remove single-numa node hack
On single-NUMA node systems the numa_node of sriov devices was sometimes reported as "-1" instead of, say, 0. This makes some tests that should succeed[0] fail unexpectedly. The reporting works as expected on real multi-NUMA node systems. This small workaround was added to handle this corner case, but it makes overall the code less readable and a bit too lenient, hence we remove it. +++ [0] on a single NUMA node system some resources are obviously always aligned if the pod can be admitted. It boils down to the node capacity at pod admittal time. Signed-off-by: Francesco Romani <[email protected]>
1 parent bb6beb9 commit 0c2827c

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

test/e2e_node/numa_alignment.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,7 @@ func (R *numaPodResources) CheckAlignment() bool {
4444
}
4545
}
4646
for _, devNode := range R.PCIDevsToNUMANode {
47-
// TODO: explain -1
48-
if devNode != -1 && nodeNum != devNode {
47+
if nodeNum != devNode {
4948
return false
5049
}
5150
}

0 commit comments

Comments
 (0)