Merge pull request kubernetes#78159 from byteor/master

k8s-ci-robot · web-flow · commit 0cea0675ec9d · 2019-05-22T15:14:37.000-07:00
[pkg/controller/serviceaccount]: refactor to more idiomatic go
diff --git a/pkg/controller/serviceaccount/serviceaccounts_controller.go b/pkg/controller/serviceaccount/serviceaccounts_controller.go
@@ -199,8 +199,7 @@ func (c *ServiceAccountsController) syncNamespace(key string) error {
 	}
 
 	createFailures := []error{}
-	for i := range c.serviceAccountsToEnsure {
-		sa := c.serviceAccountsToEnsure[i]
+	for _, sa := range c.serviceAccountsToEnsure {
 		switch _, err := c.saLister.ServiceAccounts(ns.Name).Get(sa.Name); {
 		case err == nil:
 			continue

Original file line number	Diff line number	Diff line change
`@@ -199,8 +199,7 @@ func (c *ServiceAccountsController) syncNamespace(key string) error {`
`199`	`199`	`}`
`200`	`200`
`201`	`201`	`createFailures := []error{}`
`202`		`- for i := range c.serviceAccountsToEnsure {`
`203`		`- sa := c.serviceAccountsToEnsure[i]`
	`202`	`+ for _, sa := range c.serviceAccountsToEnsure {`
`204`	`203`	`switch _, err := c.saLister.ServiceAccounts(ns.Name).Get(sa.Name); {`
`205`	`204`	`case err == nil:`
`206`	`205`	`continue`