Skip to content

Commit 0d6db3d

Browse files
authored
Merge pull request kubernetes#91294 from cofyc/fix90962-donot-change-pod-in-assume-phase
SchedulerVolumeBinder: don't modify assumed pod in AssumePodVolumes
2 parents e418766 + f685af3 commit 0d6db3d

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

pkg/controller/volume/scheduling/scheduler_binder.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ type SchedulerVolumeBinder interface {
115115
//
116116
// It returns true if all volumes are fully bound
117117
//
118-
// This function will modify assumedPod with the node name.
119118
// This function is called serially.
120119
AssumePodVolumes(assumedPod *v1.Pod, nodeName string) (allFullyBound bool, err error)
121120

@@ -334,8 +333,6 @@ func (b *volumeBinder) AssumePodVolumes(assumedPod *v1.Pod, nodeName string) (al
334333
return true, nil
335334
}
336335

337-
assumedPod.Spec.NodeName = nodeName
338-
339336
claimsToBind := b.podBindingCache.GetBindings(assumedPod, nodeName)
340337
claimsToProvision := b.podBindingCache.GetProvisionedPVCs(assumedPod, nodeName)
341338

0 commit comments

Comments
 (0)