Skip to content

Commit 0e8a2d2

Browse files
authored
Merge pull request kubernetes#90793 from pohly/flaky-mount-volume-calls
mock e2e test: reduce flakiness by not testing all calls
2 parents 0f23eef + 5aa3805 commit 0e8a2d2

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

test/e2e/storage/csi_mock_volume.go

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -770,17 +770,23 @@ var _ = utils.SIGDescribe("CSI mock volume", func() {
770770

771771
createVolume := "CreateVolume"
772772
deleteVolume := "DeleteVolume"
773-
publishVolume := "NodePublishVolume"
773+
// publishVolume := "NodePublishVolume"
774774
unpublishVolume := "NodeUnpublishVolume"
775-
stageVolume := "NodeStageVolume"
775+
// stageVolume := "NodeStageVolume"
776776
unstageVolume := "NodeUnstageVolume"
777777

778778
// These calls are assumed to occur in this order for
779-
// each test run.
779+
// each test run. NodeStageVolume and
780+
// NodePublishVolume should also be deterministic and
781+
// only get called once, but sometimes kubelet calls
782+
// both multiple times, which breaks this test
783+
// (https://github.com/kubernetes/kubernetes/issues/90250).
784+
// Therefore they are temporarily commented out until
785+
// that issue is resolved.
780786
deterministicCalls := []string{
781787
createVolume,
782-
stageVolume,
783-
publishVolume,
788+
// stageVolume,
789+
// publishVolume,
784790
unpublishVolume,
785791
unstageVolume,
786792
deleteVolume,
@@ -794,8 +800,9 @@ var _ = utils.SIGDescribe("CSI mock volume", func() {
794800
lateBinding: test.lateBinding,
795801
enableTopology: test.topology,
796802

797-
// Not strictly necessary, but without it, the external-attacher takes two minutes to detach
798-
// the volume?! Looks like a bug.
803+
// Not strictly necessary, but runs a bit faster this way
804+
// and for a while there also was a problem with a two minuted delay
805+
// due to a bug (https://github.com/kubernetes-csi/csi-test/pull/250).
799806
disableAttach: true,
800807
registerDriver: true,
801808
}

0 commit comments

Comments
 (0)