Skip to content

Commit 0ff81d0

Browse files
authored
Merge pull request kubernetes#76953 from Rand01ph/fix#69896
fix Remove hyperkube short aliases
2 parents bace505 + f6bf44a commit 0ff81d0

File tree

2 files changed

+8
-28
lines changed

2 files changed

+8
-28
lines changed

cmd/hyperkube/main.go

Lines changed: 4 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -87,30 +87,10 @@ func commandFor(basename string, defaultCommand *cobra.Command, commands []func(
8787
func NewHyperKubeCommand(stopCh <-chan struct{}) (*cobra.Command, []func() *cobra.Command) {
8888
// these have to be functions since the command is polymorphic. Cobra wants you to be top level
8989
// command to get executed
90-
apiserver := func() *cobra.Command {
91-
ret := kubeapiserver.NewAPIServerCommand(stopCh)
92-
// add back some unfortunate aliases that should be removed
93-
ret.Aliases = []string{"apiserver"}
94-
return ret
95-
}
96-
controller := func() *cobra.Command {
97-
ret := kubecontrollermanager.NewControllerManagerCommand()
98-
// add back some unfortunate aliases that should be removed
99-
ret.Aliases = []string{"controller-manager"}
100-
return ret
101-
}
102-
proxy := func() *cobra.Command {
103-
ret := kubeproxy.NewProxyCommand()
104-
// add back some unfortunate aliases that should be removed
105-
ret.Aliases = []string{"proxy"}
106-
return ret
107-
}
108-
scheduler := func() *cobra.Command {
109-
ret := kubescheduler.NewSchedulerCommand()
110-
// add back some unfortunate aliases that should be removed
111-
ret.Aliases = []string{"scheduler"}
112-
return ret
113-
}
90+
apiserver := func() *cobra.Command { return kubeapiserver.NewAPIServerCommand(stopCh) }
91+
controller := func() *cobra.Command { return kubecontrollermanager.NewControllerManagerCommand() }
92+
proxy := func() *cobra.Command { return kubeproxy.NewProxyCommand() }
93+
scheduler := func() *cobra.Command { return kubescheduler.NewSchedulerCommand() }
11494
kubectlCmd := func() *cobra.Command { return kubectl.NewDefaultKubectlCommand() }
11595
kubelet := func() *cobra.Command { return kubelet.NewKubeletCommand(stopCh) }
11696
cloudController := func() *cobra.Command { return cloudcontrollermanager.NewCloudControllerManagerCommand() }

hack/local-up-cluster.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -553,7 +553,7 @@ EOF
553553
fi
554554

555555
APISERVER_LOG=${LOG_DIR}/kube-apiserver.log
556-
${CONTROLPLANE_SUDO} "${GO_OUT}/hyperkube" apiserver "${authorizer_arg}" "${priv_arg}" ${runtime_config} \
556+
${CONTROLPLANE_SUDO} "${GO_OUT}/hyperkube" kube-apiserver "${authorizer_arg}" "${priv_arg}" ${runtime_config} \
557557
${cloud_config_arg} \
558558
"${advertise_address}" \
559559
"${node_port_range}" \
@@ -631,7 +631,7 @@ function start_controller_manager {
631631
fi
632632

633633
CTLRMGR_LOG=${LOG_DIR}/kube-controller-manager.log
634-
${CONTROLPLANE_SUDO} "${GO_OUT}/hyperkube" controller-manager \
634+
${CONTROLPLANE_SUDO} "${GO_OUT}/hyperkube" kube-controller-manager \
635635
--v="${LOG_LEVEL}" \
636636
--vmodule="${LOG_SPEC}" \
637637
--service-account-private-key-file="${SERVICE_ACCOUNT_KEY}" \
@@ -825,7 +825,7 @@ EOF
825825
fi
826826

827827
# shellcheck disable=SC2024
828-
sudo "${GO_OUT}/hyperkube" proxy \
828+
sudo "${GO_OUT}/hyperkube" kube-proxy \
829829
--v="${LOG_LEVEL}" \
830830
--config=/tmp/kube-proxy.yaml \
831831
--master="https://${API_HOST}:${API_SECURE_PORT}" >"${PROXY_LOG}" 2>&1 &
@@ -835,7 +835,7 @@ EOF
835835
function start_kubescheduler {
836836

837837
SCHEDULER_LOG=${LOG_DIR}/kube-scheduler.log
838-
${CONTROLPLANE_SUDO} "${GO_OUT}/hyperkube" scheduler \
838+
${CONTROLPLANE_SUDO} "${GO_OUT}/hyperkube" kube-scheduler \
839839
--v="${LOG_LEVEL}" \
840840
--leader-elect=false \
841841
--kubeconfig "${CERT_DIR}"/scheduler.kubeconfig \

0 commit comments

Comments
 (0)