Skip to content

Commit 1071eb8

Browse files
Remove deprecated fields from kubescheduler.config.k8s.io/v1alpha2
Signed-off-by: Aldo Culquicondor <[email protected]>
1 parent 6858c25 commit 1071eb8

File tree

7 files changed

+31
-303
lines changed

7 files changed

+31
-303
lines changed

pkg/scheduler/apis/config/v1alpha2/BUILD

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
33
go_library(
44
name = "go_default_library",
55
srcs = [
6-
"conversion.go",
76
"defaults.go",
87
"doc.go",
98
"register.go",
@@ -27,16 +26,10 @@ go_library(
2726

2827
go_test(
2928
name = "go_default_test",
30-
srcs = [
31-
"conversion_test.go",
32-
"defaults_test.go",
33-
],
29+
srcs = ["defaults_test.go"],
3430
embed = [":go_default_library"],
3531
deps = [
36-
"//pkg/scheduler/apis/config:go_default_library",
3732
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
38-
"//staging/src/k8s.io/apimachinery/pkg/conversion:go_default_library",
39-
"//staging/src/k8s.io/component-base/config:go_default_library",
4033
"//staging/src/k8s.io/component-base/config/v1alpha1:go_default_library",
4134
"//staging/src/k8s.io/kube-scheduler/config/v1alpha2:go_default_library",
4235
"//vendor/k8s.io/utils/pointer:go_default_library",

pkg/scheduler/apis/config/v1alpha2/conversion.go

Lines changed: 0 additions & 68 deletions
This file was deleted.

pkg/scheduler/apis/config/v1alpha2/conversion_test.go

Lines changed: 0 additions & 193 deletions
This file was deleted.

pkg/scheduler/apis/config/v1alpha2/defaults.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,11 +121,11 @@ func SetDefaults_KubeSchedulerConfiguration(obj *v1alpha2.KubeSchedulerConfigura
121121
if len(obj.LeaderElection.ResourceLock) == 0 {
122122
obj.LeaderElection.ResourceLock = "endpointsleases"
123123
}
124-
if len(obj.LeaderElection.LockObjectNamespace) == 0 && len(obj.LeaderElection.ResourceNamespace) == 0 {
125-
obj.LeaderElection.LockObjectNamespace = v1alpha2.SchedulerDefaultLockObjectNamespace
124+
if len(obj.LeaderElection.ResourceNamespace) == 0 {
125+
obj.LeaderElection.ResourceNamespace = v1alpha2.SchedulerDefaultLockObjectNamespace
126126
}
127-
if len(obj.LeaderElection.LockObjectName) == 0 && len(obj.LeaderElection.ResourceName) == 0 {
128-
obj.LeaderElection.LockObjectName = v1alpha2.SchedulerDefaultLockObjectName
127+
if len(obj.LeaderElection.ResourceName) == 0 {
128+
obj.LeaderElection.ResourceName = v1alpha2.SchedulerDefaultLockObjectName
129129
}
130130

131131
if len(obj.ClientConnection.ContentType) == 0 {

pkg/scheduler/apis/config/v1alpha2/defaults_test.go

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,9 @@ func TestSchedulerDefaults(t *testing.T) {
5454
RenewDeadline: metav1.Duration{Duration: 10 * time.Second},
5555
RetryPeriod: metav1.Duration{Duration: 2 * time.Second},
5656
ResourceLock: "endpointsleases",
57-
ResourceNamespace: "",
58-
ResourceName: "",
57+
ResourceNamespace: "kube-system",
58+
ResourceName: "kube-scheduler",
5959
},
60-
LockObjectName: "kube-scheduler",
61-
LockObjectNamespace: "kube-system",
6260
},
6361
ClientConnection: componentbaseconfig.ClientConnectionConfiguration{
6462
QPS: 50,
@@ -96,11 +94,9 @@ func TestSchedulerDefaults(t *testing.T) {
9694
RenewDeadline: metav1.Duration{Duration: 10 * time.Second},
9795
RetryPeriod: metav1.Duration{Duration: 2 * time.Second},
9896
ResourceLock: "endpointsleases",
99-
ResourceNamespace: "",
100-
ResourceName: "",
97+
ResourceNamespace: "kube-system",
98+
ResourceName: "kube-scheduler",
10199
},
102-
LockObjectName: "kube-scheduler",
103-
LockObjectNamespace: "kube-system",
104100
},
105101
ClientConnection: componentbaseconfig.ClientConnectionConfiguration{
106102
QPS: 50,
@@ -138,11 +134,9 @@ func TestSchedulerDefaults(t *testing.T) {
138134
RenewDeadline: metav1.Duration{Duration: 10 * time.Second},
139135
RetryPeriod: metav1.Duration{Duration: 2 * time.Second},
140136
ResourceLock: "endpointsleases",
141-
ResourceNamespace: "",
142-
ResourceName: "",
137+
ResourceNamespace: "kube-system",
138+
ResourceName: "kube-scheduler",
143139
},
144-
LockObjectName: "kube-scheduler",
145-
LockObjectNamespace: "kube-system",
146140
},
147141
ClientConnection: componentbaseconfig.ClientConnectionConfiguration{
148142
QPS: 50,

0 commit comments

Comments
 (0)