Skip to content

Commit 107595e

Browse files
authored
Merge pull request kubernetes#74074 from wojtek-t/watch_bookmark_api_changes
Watch bookmark api changes
2 parents 9f49dd2 + b0ff8dd commit 107595e

File tree

11 files changed

+3616
-634
lines changed

11 files changed

+3616
-634
lines changed

api/openapi-spec/swagger.json

Lines changed: 3347 additions & 456 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/watch/json/types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import (
3232
type WatchEvent struct {
3333
// The type of the watch event; added, modified, deleted, or error.
3434
// +optional
35-
Type watch.EventType `json:"type,omitempty" description:"the type of watch event; may be ADDED, MODIFIED, DELETED, or ERROR"`
35+
Type watch.EventType `json:"type,omitempty" description:"the type of watch event; may be ADDED, MODIFIED, DELETED, BOOKMARK or ERROR"`
3636

3737
// For added or modified objects, this is the new object; for deleted objects,
3838
// it's the state of the object immediately prior to its deletion.

staging/src/k8s.io/apiextensions-apiserver/pkg/generated/openapi/zz_generated.openapi.go

Lines changed: 8 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/apimachinery/pkg/apis/meta/internalversion/types.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,15 @@ type ListOptions struct {
3535
FieldSelector fields.Selector
3636
// If true, watch for changes to this list
3737
Watch bool
38+
// allowWatchBookmarks requests watch events with type "BOOKMARK".
39+
// Servers that do not implement bookmarks may ignore this flag and
40+
// bookmarks are sent at the server's discretion. Clients should not
41+
// assume bookmarks are returned at any specific interval, nor may they
42+
// assume the server will send any BOOKMARK event during a session.
43+
// If this is not a watch, this field is ignored.
44+
// If the feature gate WatchBookmarks is not enabled in apiserver,
45+
// this field is ignored.
46+
AllowWatchBookmarks bool
3847
// When specified with a watch call, shows changes that occur after that particular version of a resource.
3948
// Defaults to changes from the beginning of history.
4049
// When specified for list:

staging/src/k8s.io/apimachinery/pkg/apis/meta/internalversion/zz_generated.conversion.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)