Skip to content

Commit 1313385

Browse files
authored
Merge pull request kubernetes#86639 from tanjunchen/move-func-2019-12-26
move func EnableAndDisableInternalLB from test/e2e/framework/service …
2 parents 6f61072 + 2af5967 commit 1313385

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

test/e2e/framework/service/resource.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -94,12 +94,6 @@ func GetIngressPoint(ing *v1.LoadBalancerIngress) string {
9494
return host
9595
}
9696

97-
// EnableAndDisableInternalLB returns two functions for enabling and disabling the internal load balancer
98-
// setting for the supported cloud providers (currently GCE/GKE and Azure) and empty functions for others.
99-
func EnableAndDisableInternalLB() (enable func(svc *v1.Service), disable func(svc *v1.Service)) {
100-
return framework.TestContext.CloudConfig.Provider.EnableAndDisableInternalLB()
101-
}
102-
10397
// GetServiceLoadBalancerCreationTimeout returns a timeout value for creating a load balancer of a service.
10498
func GetServiceLoadBalancerCreationTimeout(cs clientset.Interface) time.Duration {
10599
nodes, err := e2enode.GetReadySchedulableNodes(cs)

test/e2e/network/service.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2173,7 +2173,7 @@ var _ = SIGDescribe("Services", func() {
21732173
_, err := jig.Run(nil)
21742174
framework.ExpectNoError(err)
21752175

2176-
enableILB, disableILB := e2eservice.EnableAndDisableInternalLB()
2176+
enableILB, disableILB := enableAndDisableInternalLB()
21772177

21782178
isInternalEndpoint := func(lbIngress *v1.LoadBalancerIngress) bool {
21792179
ingressEndpoint := e2eservice.GetIngressPoint(lbIngress)
@@ -3243,3 +3243,9 @@ func proxyMode(f *framework.Framework) (string, error) {
32433243
framework.Logf("proxyMode: %s", stdout)
32443244
return stdout, nil
32453245
}
3246+
3247+
// enableAndDisableInternalLB returns two functions for enabling and disabling the internal load balancer
3248+
// setting for the supported cloud providers (currently GCE/GKE and Azure) and empty functions for others.
3249+
func enableAndDisableInternalLB() (enable func(svc *v1.Service), disable func(svc *v1.Service)) {
3250+
return framework.TestContext.CloudConfig.Provider.EnableAndDisableInternalLB()
3251+
}

0 commit comments

Comments
 (0)