Skip to content

Commit 1377108

Browse files
authored
Merge pull request kubernetes#76808 from SataQiu/fix-hack-shellcheck-20190419
Fix shellcheck failures of hack/verify-readonly-packages.sh
2 parents b1fea1b + 43095d9 commit 1377108

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

hack/verify-readonly-packages.sh

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -43,19 +43,13 @@ find_files() {
4343
\) -name '.readonly'
4444
}
4545

46-
IFS=$'\n'
47-
4846
conflicts=()
49-
while IFS=$'\n' read -r line; do
50-
conflicts+=( "$line" )
51-
done < <(find_files | sed 's|/.readonly||' | while read -r dir; do
47+
while IFS=$'\n' read -r dir; do
5248
dir=${dir#./}
5349
if kube::util::has_changes "${branch}" "^${dir}/[^/]*\$" '/\.readonly$|/BUILD$|/zz_generated|/\.generated\.|\.proto$|\.pb\.go$' >/dev/null; then
54-
echo "${dir}"
50+
conflicts+=("${dir}")
5551
fi
56-
done)
57-
58-
unset IFS
52+
done < <(find_files | sed 's|/.readonly||')
5953

6054
if [ ${#conflicts[@]} -gt 0 ]; then
6155
exec 1>&2

0 commit comments

Comments
 (0)