Skip to content

Commit 1590c7b

Browse files
authored
Merge pull request kubernetes#87371 from ii/promote-limit-range-defaults-test
Add: promotion for LimitRange defaults test to Conformance
2 parents f5a0087 + bc2aaba commit 1590c7b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

test/conformance/testdata/conformance.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,7 @@ test/e2e/network/service_latency.go: "should not be very high"
266266
test/e2e/node/events.go: "should be sent by kubelets and the scheduler about pods scheduling and running"
267267
test/e2e/node/pods.go: "should be set on Pods with matching resource requests and limits for memory and cpu"
268268
test/e2e/node/pre_stop.go: "should call prestop when killing a pod"
269+
test/e2e/scheduling/limit_range.go: "should create a LimitRange with defaults and ensure pod has those defaults applied."
269270
test/e2e/scheduling/predicates.go: "validates resource limits of pods that are allowed to run"
270271
test/e2e/scheduling/predicates.go: "validates that NodeSelector is respected if not matching"
271272
test/e2e/scheduling/predicates.go: "validates that NodeSelector is respected if matching"

test/e2e/scheduling/limit_range.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,11 @@ var _ = SIGDescribe("LimitRange", func() {
4747
f := framework.NewDefaultFramework("limitrange")
4848

4949
/*
50-
Release : v1.15
50+
Release : v1.18
5151
Testname: LimitRange, resources
5252
Description: Creating a Limitrange and verifying the creation of Limitrange, updating the Limitrange and validating the Limitrange. Creating Pods with resources and validate the pod resources are applied to the Limitrange
5353
*/
54-
//note: this test case can be promoted to conformance after verified the stability of the test case
55-
ginkgo.It("should create a LimitRange with defaults and ensure pod has those defaults applied.", func() {
54+
framework.ConformanceIt("should create a LimitRange with defaults and ensure pod has those defaults applied.", func() {
5655
ginkgo.By("Creating a LimitRange")
5756
min := getResourceList("50m", "100Mi", "100Gi")
5857
max := getResourceList("500m", "500Mi", "500Gi")

0 commit comments

Comments
 (0)