Windows: Fixes subpath symlink evaluation

claudiubelu · claudiubelu · commit 15ccf86e7c14 · 2020-07-13T16:12:01.000-07:00
Paths do not always have Targets, which means that the previously added powershell
command will return an empty string, causing pods with subpath mounts to fail.
diff --git a/pkg/volume/util/subpath/subpath_windows.go b/pkg/volume/util/subpath/subpath_windows.go
@@ -55,6 +55,10 @@ func evalPath(path string) (linkedPath string, err error) {
 		return "", err
 	}
 	linkedPath = strings.TrimSpace(string(output))
+	if linkedPath == "" {
+		klog.V(4).Infof("Path '%s' has no target. Consiering it as evaluated.", path)
+		return path, nil
+	}
 	if isVolumePrefix(linkedPath) {
 		return path, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,10 @@ func evalPath(path string) (linkedPath string, err error) {`
`55`	`55`	`return "", err`
`56`	`56`	`}`
`57`	`57`	`linkedPath = strings.TrimSpace(string(output))`
	`58`	`+ if linkedPath == "" {`
	`59`	`+ klog.V(4).Infof("Path '%s' has no target. Consiering it as evaluated.", path)`
	`60`	`+ return path, nil`
	`61`	`+ }`
`58`	`62`	`if isVolumePrefix(linkedPath) {`
`59`	`63`	`return path, err`
`60`	`64`	`}`