Skip to content

Commit 163b23f

Browse files
authored
Merge pull request kubernetes#95529 from cici37/cleanup
Add back openapi gen for generic types and clean up doc.go
2 parents 0900340 + 0d20022 commit 163b23f

File tree

4 files changed

+13
-3
lines changed

4 files changed

+13
-3
lines changed

api/api-rules/violation_exceptions.list

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -368,6 +368,8 @@ API rule violation: list_type_missing,k8s.io/apiserver/pkg/apis/audit/v1beta1,Po
368368
API rule violation: list_type_missing,k8s.io/apiserver/pkg/apis/audit/v1beta1,PolicyRule,UserGroups
369369
API rule violation: list_type_missing,k8s.io/apiserver/pkg/apis/audit/v1beta1,PolicyRule,Users
370370
API rule violation: list_type_missing,k8s.io/apiserver/pkg/apis/audit/v1beta1,PolicyRule,Verbs
371+
API rule violation: list_type_missing,k8s.io/controller-manager/config/v1alpha1,GenericControllerManagerConfiguration,Controllers
372+
API rule violation: list_type_missing,k8s.io/controller-manager/config/v1alpha1,LeaderMigrationConfiguration,ControllerLeaders
371373
API rule violation: list_type_missing,k8s.io/kube-controller-manager/config/v1alpha1,GarbageCollectorControllerConfiguration,GCIgnoredResources
372374
API rule violation: list_type_missing,k8s.io/kube-controller-manager/config/v1alpha1,PersistentVolumeBinderControllerConfiguration,VolumeHostCIDRDenylist
373375
API rule violation: list_type_missing,k8s.io/kube-proxy/config/v1alpha1,KubeProxyConfiguration,NodePortAddresses
@@ -484,6 +486,14 @@ API rule violation: names_match,k8s.io/cloud-provider/app/apis/config/v1alpha1,K
484486
API rule violation: names_match,k8s.io/cloud-provider/app/apis/config/v1alpha1,KubeCloudSharedConfiguration,NodeSyncPeriod
485487
API rule violation: names_match,k8s.io/cloud-provider/app/apis/config/v1alpha1,KubeCloudSharedConfiguration,RouteReconciliationPeriod
486488
API rule violation: names_match,k8s.io/cloud-provider/app/apis/config/v1alpha1,KubeCloudSharedConfiguration,UseServiceAccountCredentials
489+
API rule violation: names_match,k8s.io/controller-manager/config/v1alpha1,GenericControllerManagerConfiguration,Address
490+
API rule violation: names_match,k8s.io/controller-manager/config/v1alpha1,GenericControllerManagerConfiguration,ClientConnection
491+
API rule violation: names_match,k8s.io/controller-manager/config/v1alpha1,GenericControllerManagerConfiguration,ControllerStartInterval
492+
API rule violation: names_match,k8s.io/controller-manager/config/v1alpha1,GenericControllerManagerConfiguration,Controllers
493+
API rule violation: names_match,k8s.io/controller-manager/config/v1alpha1,GenericControllerManagerConfiguration,Debugging
494+
API rule violation: names_match,k8s.io/controller-manager/config/v1alpha1,GenericControllerManagerConfiguration,LeaderElection
495+
API rule violation: names_match,k8s.io/controller-manager/config/v1alpha1,GenericControllerManagerConfiguration,MinResyncPeriod
496+
API rule violation: names_match,k8s.io/controller-manager/config/v1alpha1,GenericControllerManagerConfiguration,Port
487497
API rule violation: names_match,k8s.io/kube-controller-manager/config/v1alpha1,AttachDetachControllerConfiguration,DisableAttachDetachReconcilerSync
488498
API rule violation: names_match,k8s.io/kube-controller-manager/config/v1alpha1,AttachDetachControllerConfiguration,ReconcilerSyncLoopPeriod
489499
API rule violation: names_match,k8s.io/kube-controller-manager/config/v1alpha1,CSRSigningConfiguration,CertFile

build/kazel_generated.bzl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ tags_values_pkgs = {"openapi-gen": {
9494
"staging/src/k8s.io/client-go/pkg/apis/clientauthentication/v1beta1",
9595
"staging/src/k8s.io/client-go/pkg/version",
9696
"staging/src/k8s.io/cloud-provider/app/apis/config/v1alpha1",
97+
"staging/src/k8s.io/controller-manager/config/v1alpha1",
9798
"staging/src/k8s.io/kube-aggregator/pkg/apis/apiregistration/v1",
9899
"staging/src/k8s.io/kube-aggregator/pkg/apis/apiregistration/v1beta1",
99100
"staging/src/k8s.io/kube-controller-manager/config/v1alpha1",
@@ -180,6 +181,7 @@ tags_pkgs_values = {"openapi-gen": {
180181
"staging/src/k8s.io/client-go/pkg/apis/clientauthentication/v1beta1": ["true"],
181182
"staging/src/k8s.io/client-go/pkg/version": ["true"],
182183
"staging/src/k8s.io/cloud-provider/app/apis/config/v1alpha1": ["true"],
184+
"staging/src/k8s.io/controller-manager/config/v1alpha1": ["true"],
183185
"staging/src/k8s.io/kube-aggregator/pkg/apis/apiregistration/v1": ["true"],
184186
"staging/src/k8s.io/kube-aggregator/pkg/apis/apiregistration/v1beta1": ["true"],
185187
"staging/src/k8s.io/kube-controller-manager/config/v1alpha1": ["true"],

pkg/controller/apis/config/v1alpha1/doc.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,8 @@ limitations under the License.
1717
// +k8s:deepcopy-gen=package
1818
// +k8s:conversion-gen=k8s.io/kubernetes/pkg/controller/apis/config
1919
// +k8s:conversion-gen=k8s.io/component-base/config/v1alpha1
20-
// +k8s:conversion-gen=k8s.io/cloud-provider/app/apis/config
2120
// +k8s:conversion-gen=k8s.io/cloud-provider/app/apis/config/v1alpha1
22-
// +k8s:conversion-gen=k8s.io/cloud-provider/service/config
2321
// +k8s:conversion-gen=k8s.io/cloud-provider/service/config/v1alpha1
24-
// +k8s:conversion-gen=k8s.io/controller-manager/config
2522
// +k8s:conversion-gen=k8s.io/controller-manager/config/v1alpha1
2623
// +k8s:conversion-gen=k8s.io/kubernetes/pkg/controller/certificates/signer/config/v1alpha1
2724
// +k8s:conversion-gen=k8s.io/kubernetes/pkg/controller/daemon/config/v1alpha1

staging/src/k8s.io/controller-manager/config/v1alpha1/doc.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ limitations under the License.
1717
// +k8s:deepcopy-gen=package
1818
// +k8s:conversion-gen=k8s.io/controller-manager/config
1919
// +k8s:conversion-gen=k8s.io/controller-manager/config/v1alpha1
20+
// +k8s:openapi-gen=true
2021
// +groupName=controllermanager.config.k8s.io
2122

2223
package v1alpha1 // import "k8s.io/controller-manager/config/v1alpha1"

0 commit comments

Comments
 (0)