Merge pull request kubernetes#91423 from gaurav1086/kubectl_use_FprintF

k8s-ci-robot · web-flow · commit 16ea9dc6bc26 · 2020-09-05T15:07:41.000-07:00
kubectl: Use Fprintf
diff --git a/staging/src/k8s.io/kubectl/pkg/cmd/get/get.go b/staging/src/k8s.io/kubectl/pkg/cmd/get/get.go
@@ -582,9 +582,9 @@ func (o *GetOptions) Run(f cmdutil.Factory, cmd *cobra.Command, args []string) e
 	if trackingWriter.Written == 0 && !o.IgnoreNotFound && len(allErrs) == 0 {
 		// if we wrote no output, and had no errors, and are not ignoring NotFound, be sure we output something
 		if allResourcesNamespaced {
-			fmt.Fprintln(o.ErrOut, fmt.Sprintf("No resources found in %s namespace.", o.Namespace))
+			fmt.Fprintf(o.ErrOut, "No resources found in %s namespace.\n", o.Namespace)
 		} else {
-			fmt.Fprintln(o.ErrOut, fmt.Sprintf("No resources found"))
+			fmt.Fprintln(o.ErrOut, "No resources found")
 		}
 	}
 	return utilerrors.NewAggregate(allErrs)

Original file line number	Diff line number	Diff line change
`@@ -582,9 +582,9 @@ func (o GetOptions) Run(f cmdutil.Factory, cmd cobra.Command, args []string) e`
`582`	`582`	`if trackingWriter.Written == 0 && !o.IgnoreNotFound && len(allErrs) == 0 {`
`583`	`583`	`// if we wrote no output, and had no errors, and are not ignoring NotFound, be sure we output something`
`584`	`584`	`if allResourcesNamespaced {`
`585`		`- fmt.Fprintln(o.ErrOut, fmt.Sprintf("No resources found in %s namespace.", o.Namespace))`
	`585`	`+ fmt.Fprintf(o.ErrOut, "No resources found in %s namespace.\n", o.Namespace)`
`586`	`586`	`} else {`
`587`		`- fmt.Fprintln(o.ErrOut, fmt.Sprintf("No resources found"))`
	`587`	`+ fmt.Fprintln(o.ErrOut, "No resources found")`
`588`	`588`	`}`
`589`	`589`	`}`
`590`	`590`	`return utilerrors.NewAggregate(allErrs)`