Merge pull request kubernetes#91160 from gaurav1086/kube_aggregator_fix_goroutine_leak

k8s-ci-robot · web-flow · commit 17616aa9cc64 · 2020-06-15T05:28:11.000-07:00
kube-aggregator: Fix goroutine leak
diff --git a/staging/src/k8s.io/kube-aggregator/pkg/controllers/status/available_controller.go b/staging/src/k8s.io/kube-aggregator/pkg/controllers/status/available_controller.go
@@ -292,7 +292,7 @@ func (c *AvailableConditionController) sync(key string) error {
 					discoveryURL.Path = "/apis/" + apiService.Spec.Group + "/" + apiService.Spec.Version
 				}
 
-				errCh := make(chan error)
+				errCh := make(chan error, 1)
 				go func() {
 					// be sure to check a URL that the aggregated API server is required to serve
 					newReq, err := http.NewRequest("GET", discoveryURL.String(), nil)

Original file line number	Diff line number	Diff line change
`@@ -292,7 +292,7 @@ func (c *AvailableConditionController) sync(key string) error {`
`292`	`292`	`discoveryURL.Path = "/apis/" + apiService.Spec.Group + "/" + apiService.Spec.Version`
`293`	`293`	`}`
`294`	`294`
`295`		`- errCh := make(chan error)`
	`295`	`+ errCh := make(chan error, 1)`
`296`	`296`	`go func() {`
`297`	`297`	`// be sure to check a URL that the aggregated API server is required to serve`
`298`	`298`	`newReq, err := http.NewRequest("GET", discoveryURL.String(), nil)`