Skip to content

Commit 17fe18b

Browse files
authored
Merge pull request kubernetes#76474 from vincepri/update-klog-030
Update klog to 0.3.0
2 parents bd62503 + 3f55226 commit 17fe18b

File tree

43 files changed

+140
-104
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+140
-104
lines changed

cmd/kubelet/app/options/globalflags.go

Lines changed: 7 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ import (
2626

2727
// libs that provide registration functions
2828
"k8s.io/component-base/logs"
29+
"k8s.io/klog"
2930
"k8s.io/kubernetes/pkg/version/verflag"
3031

3132
// ensure libs have a chance to globally register their flags
32-
_ "k8s.io/klog"
3333
_ "k8s.io/kubernetes/pkg/credentialprovider/azure"
3434
_ "k8s.io/kubernetes/pkg/credentialprovider/gcp"
3535
)
@@ -38,7 +38,7 @@ import (
3838
// against the global flagsets from "flag" and "github.com/spf13/pflag".
3939
// We do this in order to prevent unwanted flags from leaking into the Kubelet's flagset.
4040
func AddGlobalFlags(fs *pflag.FlagSet) {
41-
addGlogFlags(fs)
41+
addKlogFlags(fs)
4242
addCadvisorFlags(fs)
4343
addCredentialProviderFlags(fs)
4444
verflag.AddFlags(fs)
@@ -91,20 +91,9 @@ func addCredentialProviderFlags(fs *pflag.FlagSet) {
9191
fs.AddFlagSet(local)
9292
}
9393

94-
// addGlogFlags adds flags from k8s.io/klog
95-
func addGlogFlags(fs *pflag.FlagSet) {
96-
// lookup flags in global flag set and re-register the values with our flagset
97-
global := flag.CommandLine
98-
local := pflag.NewFlagSet(os.Args[0], pflag.ExitOnError)
99-
100-
register(global, local, "logtostderr")
101-
register(global, local, "alsologtostderr")
102-
register(global, local, "v")
103-
register(global, local, "stderrthreshold")
104-
register(global, local, "vmodule")
105-
register(global, local, "log_backtrace_at")
106-
register(global, local, "log_dir")
107-
register(global, local, "log_file")
108-
109-
fs.AddFlagSet(local)
94+
// addKlogFlags adds flags from k8s.io/klog
95+
func addKlogFlags(fs *pflag.FlagSet) {
96+
local := flag.NewFlagSet(os.Args[0], flag.ExitOnError)
97+
klog.InitFlags(local)
98+
fs.AddGoFlagSet(local)
11099
}

go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ require (
184184
k8s.io/csi-translation-lib v0.0.0
185185
k8s.io/gengo v0.0.0-20190116091435-f8a0810f38af
186186
k8s.io/heapster v1.2.0-beta.1
187-
k8s.io/klog v0.0.0-20190306015804-8e90cee79f82
187+
k8s.io/klog v0.3.0
188188
k8s.io/kube-aggregator v0.0.0
189189
k8s.io/kube-controller-manager v0.0.0
190190
k8s.io/kube-openapi v0.0.0-20190228160746-b3a7cee44a30
@@ -451,7 +451,7 @@ replace (
451451
k8s.io/csi-translation-lib => ./staging/src/k8s.io/csi-translation-lib
452452
k8s.io/gengo => k8s.io/gengo v0.0.0-20190116091435-f8a0810f38af
453453
k8s.io/heapster => k8s.io/heapster v1.2.0-beta.1
454-
k8s.io/klog => k8s.io/klog v0.0.0-20190306015804-8e90cee79f82
454+
k8s.io/klog => k8s.io/klog v0.3.0
455455
k8s.io/kube-aggregator => ./staging/src/k8s.io/kube-aggregator
456456
k8s.io/kube-controller-manager => ./staging/src/k8s.io/kube-controller-manager
457457
k8s.io/kube-openapi => k8s.io/kube-openapi v0.0.0-20190228160746-b3a7cee44a30

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -470,8 +470,8 @@ k8s.io/gengo v0.0.0-20190116091435-f8a0810f38af h1:SwjZbO0u5ZuaV6TRMWOGB40iaycX8
470470
k8s.io/gengo v0.0.0-20190116091435-f8a0810f38af/go.mod h1:ezvh/TsK7cY6rbqRK0oQQ8IAqLxYwwyPxAX1Pzy0ii0=
471471
k8s.io/heapster v1.2.0-beta.1 h1:lUsE/AHOMHpi3MLlBEkaU8Esxm5QhdyCrv1o7ot0s84=
472472
k8s.io/heapster v1.2.0-beta.1/go.mod h1:h1uhptVXMwC8xtZBYsPXKVi8fpdlYkTs6k949KozGrM=
473-
k8s.io/klog v0.0.0-20190306015804-8e90cee79f82 h1:SHucoAy7lRb+w5oC/hbXyZg+zX+Wftn6hD4tGzHCVqA=
474-
k8s.io/klog v0.0.0-20190306015804-8e90cee79f82/go.mod h1:Gq+BEi5rUBO/HRz0bTSXDUcqjScdoY3a9IHpCEIOOfk=
473+
k8s.io/klog v0.3.0 h1:0VPpR+sizsiivjIfIAQH/rl8tan6jvWkS7lU+0di3lE=
474+
k8s.io/klog v0.3.0/go.mod h1:Gq+BEi5rUBO/HRz0bTSXDUcqjScdoY3a9IHpCEIOOfk=
475475
k8s.io/kube-openapi v0.0.0-20190228160746-b3a7cee44a30 h1:TRb4wNWoBVrH9plmkp2q86FIDppkbrEXdXlxU3a3BMI=
476476
k8s.io/kube-openapi v0.0.0-20190228160746-b3a7cee44a30/go.mod h1:BXM9ceUBTj2QnfH2MK1odQs778ajze1RxcmP6S8RVVc=
477477
k8s.io/repo-infra v0.0.0-20181204233714-00fe14e3d1a3 h1:WD6cPA3q7qxZe6Fwir0XjjGwGMaWbHlHUcjCcOzuRG0=

staging/src/k8s.io/api/go.sum

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/apiextensions-apiserver/go.mod

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/apiextensions-apiserver/go.sum

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/apimachinery/go.mod

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/apimachinery/go.sum

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/apiserver/go.mod

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/apiserver/go.sum

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)