Skip to content

Commit 184fe99

Browse files
authored
Merge pull request kubernetes#89592 from dcbw/e2e-np-previous-logs
e2e/network: get previous pod logs on NetworkPolicy test failure
2 parents 933c303 + fe74d08 commit 184fe99

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

test/e2e/network/network_policy.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"encoding/json"
2222
v1 "k8s.io/api/core/v1"
2323
networkingv1 "k8s.io/api/networking/v1"
24+
apierrors "k8s.io/apimachinery/pkg/api/errors"
2425
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2526
"k8s.io/apimachinery/pkg/types"
2627
"k8s.io/apimachinery/pkg/util/intstr"
@@ -1566,9 +1567,14 @@ func checkNoConnectivityByExitCode(f *framework.Framework, ns *v1.Namespace, pod
15661567
func collectPodsAndNetworkPolicies(f *framework.Framework, podClient *v1.Pod) ([]string, *networkingv1.NetworkPolicyList, string) {
15671568
// Collect pod logs when we see a failure.
15681569
logs, logErr := e2epod.GetPodLogs(f.ClientSet, f.Namespace.Name, podClient.Name, "client")
1570+
if logErr != nil && apierrors.IsNotFound(logErr) {
1571+
// Pod may have already been removed; try to get previous pod logs
1572+
logs, logErr = e2epod.GetPreviousPodLogs(f.ClientSet, f.Namespace.Name, podClient.Name, fmt.Sprintf("%s-container", podClient.Name))
1573+
}
15691574
if logErr != nil {
15701575
framework.Failf("Error getting container logs: %s", logErr)
15711576
}
1577+
15721578
// Collect current NetworkPolicies applied in the test namespace.
15731579
policies, err := f.ClientSet.NetworkingV1().NetworkPolicies(f.Namespace.Name).List(context.TODO(), metav1.ListOptions{})
15741580
if err != nil {

0 commit comments

Comments
 (0)