Remove duplicated check in ObserveEventAfterAction

Kenichi Omichi · Kenichi Omichi · commit 18e3807cd763 · 2019-07-27T01:03:10.000Z
In ObserveEventAfterAction(), observedMatchingEvent is set if ok is
true. Now the ok is already checked with framework.ExpectEqual().
So this removes duplicated check for code cleanup.
diff --git a/test/e2e/common/events.go b/test/e2e/common/events.go
@@ -121,7 +121,7 @@ func ObserveEventAfterAction(f *framework.Framework, eventPredicate func(*v1.Eve
 				e, ok := obj.(*v1.Event)
 				ginkgo.By(fmt.Sprintf("Considering event: \nType = [%s], Name = [%s], Reason = [%s], Message = [%s]", e.Type, e.Name, e.Reason, e.Message))
 				framework.ExpectEqual(ok, true)
-				if ok && eventPredicate(e) {
+				if eventPredicate(e) {
 					observedMatchingEvent = true
 				}
 			},

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ func ObserveEventAfterAction(f framework.Framework, eventPredicate func(v1.Eve`
`121`	`121`	`e, ok := obj.(*v1.Event)`
`122`	`122`	`ginkgo.By(fmt.Sprintf("Considering event: \nType = [%s], Name = [%s], Reason = [%s], Message = [%s]", e.Type, e.Name, e.Reason, e.Message))`
`123`	`123`	`framework.ExpectEqual(ok, true)`
`124`		`- if ok && eventPredicate(e) {`
	`124`	`+ if eventPredicate(e) {`
`125`	`125`	`observedMatchingEvent = true`
`126`	`126`	`}`
`127`	`127`	`},`