Skip to content

Commit 1a0a757

Browse files
authored
Merge pull request kubernetes#76613 from SataQiu/fix-golint-20190416
Fix golint failures of pkg/apis/core/helper
2 parents 123b9c9 + 556ff16 commit 1a0a757

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

hack/.golint_failures

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ pkg/apis/certificates
3131
pkg/apis/certificates/v1beta1
3232
pkg/apis/certificates/validation
3333
pkg/apis/core
34-
pkg/apis/core/helper
3534
pkg/apis/core/helper/qos
3635
pkg/apis/core/v1
3736
pkg/apis/core/v1/helper

pkg/apis/core/helper/helpers.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,10 +276,12 @@ var standardFinalizers = sets.NewString(
276276
metav1.FinalizerDeleteDependents,
277277
)
278278

279+
// IsStandardFinalizerName checks if the input string is a standard finalizer name
279280
func IsStandardFinalizerName(str string) bool {
280281
return standardFinalizers.Has(str)
281282
}
282283

284+
// LoadBalancerStatusEqual checks if the status of the load balancer is equal to the target status
283285
// TODO: make method on LoadBalancerStatus?
284286
func LoadBalancerStatusEqual(l, r *core.LoadBalancerStatus) bool {
285287
return ingressSliceEqual(l.Ingress, r.Ingress)
@@ -324,7 +326,7 @@ func GetAccessModesAsString(modes []core.PersistentVolumeAccessMode) string {
324326
return strings.Join(modesStr, ",")
325327
}
326328

327-
// GetAccessModesAsString returns an array of AccessModes from a string created by GetAccessModesAsString
329+
// GetAccessModesFromString returns an array of AccessModes from a string created by GetAccessModesAsString
328330
func GetAccessModesFromString(modes string) []core.PersistentVolumeAccessMode {
329331
strmodes := strings.Split(modes, ",")
330332
accessModes := []core.PersistentVolumeAccessMode{}

0 commit comments

Comments
 (0)