Fix misleading kube-proxy logs about IPversion mismatch.

vllry · vllry · commit 1bb55091a1a7 · 2019-10-05T18:28:29.000-07:00
diff --git a/pkg/proxy/endpoints.go b/pkg/proxy/endpoints.go
@@ -327,7 +327,7 @@ func (ect *EndpointChangeTracker) endpointsToEndpointsMap(endpoints *v1.Endpoint
 				if ect.isIPv6Mode != nil && utilnet.IsIPv6String(addr.IP) != *ect.isIPv6Mode {
 					// Emit event on the corresponding service which had a different
 					// IP version than the endpoint.
-					utilproxy.LogAndEmitIncorrectIPVersionEvent(ect.recorder, "endpoints", addr.IP, endpoints.Name, endpoints.Namespace, "")
+					utilproxy.LogAndEmitIncorrectIPVersionEvent(ect.recorder, "endpoints", addr.IP, endpoints.Namespace, endpoints.Name, "")
 					continue
 				}
 				isLocal := addr.NodeName != nil && *addr.NodeName == ect.hostname

Original file line number	Diff line number	Diff line change
`@@ -327,7 +327,7 @@ func (ect EndpointChangeTracker) endpointsToEndpointsMap(endpoints v1.Endpoint`
`327`	`327`	`if ect.isIPv6Mode != nil && utilnet.IsIPv6String(addr.IP) != *ect.isIPv6Mode {`
`328`	`328`	`// Emit event on the corresponding service which had a different`
`329`	`329`	`// IP version than the endpoint.`
`330`		`- utilproxy.LogAndEmitIncorrectIPVersionEvent(ect.recorder, "endpoints", addr.IP, endpoints.Name, endpoints.Namespace, "")`
	`330`	`+ utilproxy.LogAndEmitIncorrectIPVersionEvent(ect.recorder, "endpoints", addr.IP, endpoints.Namespace, endpoints.Name, "")`
`331`	`331`	`continue`
`332`	`332`	`}`
`333`	`333`	`isLocal := addr.NodeName != nil && *addr.NodeName == ect.hostname`