Merge pull request kubernetes#94605 from yttan/lint

k8s-ci-robot · web-flow · commit 1c6057b59ca7 · 2020-09-08T21:35:52.000-07:00
fix golint failures for staging/src/k8s.io/client-go/examples/workqueue
diff --git a/hack/.golint_failures b/hack/.golint_failures
@@ -381,7 +381,6 @@ staging/src/k8s.io/client-go/discovery
 staging/src/k8s.io/client-go/discovery/fake
 staging/src/k8s.io/client-go/dynamic
 staging/src/k8s.io/client-go/dynamic/fake
-staging/src/k8s.io/client-go/examples/workqueue
 staging/src/k8s.io/client-go/kubernetes/typed/certificates/v1beta1
 staging/src/k8s.io/client-go/kubernetes/typed/certificates/v1beta1/fake
 staging/src/k8s.io/client-go/kubernetes/typed/core/v1
diff --git a/staging/src/k8s.io/client-go/examples/workqueue/main.go b/staging/src/k8s.io/client-go/examples/workqueue/main.go
@@ -34,12 +34,14 @@ import (
 	"k8s.io/client-go/util/workqueue"
 )
 
+// Controller demonstrates how to implement a controller with client-go.
 type Controller struct {
 	indexer  cache.Indexer
 	queue    workqueue.RateLimitingInterface
 	informer cache.Controller
 }
 
+// NewController creates a new Controller.
 func NewController(queue workqueue.RateLimitingInterface, indexer cache.Indexer, informer cache.Controller) *Controller {
 	return &Controller{
 		informer: informer,
@@ -113,6 +115,7 @@ func (c *Controller) handleErr(err error, key interface{}) {
 	klog.Infof("Dropping pod %q out of the queue: %v", key, err)
 }
 
+// Run begins watching and syncing.
 func (c *Controller) Run(threadiness int, stopCh chan struct{}) {
 	defer runtime.HandleCrash()
 

Original file line number	Diff line number	Diff line change
`@@ -34,12 +34,14 @@ import (`
`34`	`34`	`"k8s.io/client-go/util/workqueue"`
`35`	`35`	`)`
`36`	`36`
	`37`	`+// Controller demonstrates how to implement a controller with client-go.`
`37`	`38`	`type Controller struct {`
`38`	`39`	`indexer cache.Indexer`
`39`	`40`	`queue workqueue.RateLimitingInterface`
`40`	`41`	`informer cache.Controller`
`41`	`42`	`}`
`42`	`43`
	`44`	`+// NewController creates a new Controller.`
`43`	`45`	`func NewController(queue workqueue.RateLimitingInterface, indexer cache.Indexer, informer cache.Controller) *Controller {`
`44`	`46`	`return &Controller{`
`45`	`47`	`informer: informer,`
`@@ -113,6 +115,7 @@ func (c *Controller) handleErr(err error, key interface{}) {`
`113`	`115`	`klog.Infof("Dropping pod %q out of the queue: %v", key, err)`
`114`	`116`	`}`
`115`	`117`
	`118`	`+// Run begins watching and syncing.`
`116`	`119`	`func (c *Controller) Run(threadiness int, stopCh chan struct{}) {`
`117`	`120`	`defer runtime.HandleCrash()`
`118`	`121`