Skip to content

Commit 1d72455

Browse files
authored
Merge pull request kubernetes#82696 from mm4tt/nginx_custom_lb_timeout
Adjust nginx lb timeout depending on the cluster size in tests
2 parents 9d8acc0 + 532298c commit 1d72455

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

test/e2e/framework/ingress/ingress_utils.go

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -831,6 +831,7 @@ type NginxIngressController struct {
831831
rc *v1.ReplicationController
832832
pod *v1.Pod
833833
Client clientset.Interface
834+
lbSvc *v1.Service
834835
}
835836

836837
// Init initializes the NginxIngressController
@@ -848,8 +849,8 @@ func (cont *NginxIngressController) Init() {
848849
{Name: "https", Port: 443},
849850
{Name: "stats", Port: 18080}}
850851
})
851-
svc := serviceJig.WaitForLoadBalancerOrFail(cont.Ns, "nginx-ingress-lb", e2eservice.LoadBalancerCreateTimeoutDefault)
852-
serviceJig.SanityCheckService(svc, v1.ServiceTypeLoadBalancer)
852+
cont.lbSvc = serviceJig.WaitForLoadBalancerOrFail(cont.Ns, "nginx-ingress-lb", e2eservice.GetServiceLoadBalancerCreationTimeout(cont.Client))
853+
serviceJig.SanityCheckService(cont.lbSvc, v1.ServiceTypeLoadBalancer)
853854

854855
read := func(file string) string {
855856
return string(testfiles.ReadOrDie(filepath.Join(IngressManifestPath, "nginx", file)))
@@ -873,6 +874,15 @@ func (cont *NginxIngressController) Init() {
873874
framework.Logf("ingress controller running in pod %v", cont.pod.Name)
874875
}
875876

877+
// TearDown cleans up the NginxIngressController.
878+
func (cont *NginxIngressController) TearDown() {
879+
if cont.lbSvc == nil {
880+
framework.Logf("No LoadBalancer service created, no cleanup necessary")
881+
return
882+
}
883+
e2eservice.WaitForServiceDeletedWithFinalizer(cont.Client, cont.Ns, cont.lbSvc.Name)
884+
}
885+
876886
func generateBacksideHTTPSIngressSpec(ns string) *networkingv1beta1.Ingress {
877887
return &networkingv1beta1.Ingress{
878888
ObjectMeta: metav1.ObjectMeta{

test/e2e/network/ingress.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -737,6 +737,7 @@ var _ = SIGDescribe("Loadbalancing: L7", func() {
737737
if ginkgo.CurrentGinkgoTestDescription().Failed {
738738
framework.DescribeIng(ns)
739739
}
740+
defer nginxController.TearDown()
740741
if jig.Ingress == nil {
741742
ginkgo.By("No ingress created, no cleanup necessary")
742743
return

0 commit comments

Comments
 (0)