Skip to content

Commit 1e84adb

Browse files
authored
Merge pull request kubernetes#88139 from BenTheElder/pause-manifest
switch pause to docker manifest instead of manifest-tool
2 parents 48434c3 + becc4b7 commit 1e84adb

File tree

3 files changed

+4
-36
lines changed

3 files changed

+4
-36
lines changed

build/pause/Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414

1515
.PHONY: all push container clean orphan all-push push-manifest
1616

17-
include ../../hack/make-rules/Makefile.manifest
18-
1917
REGISTRY ?= staging-k8s.gcr.io
2018
IMAGE = $(REGISTRY)/pause
2119
IMAGE_WITH_ARCH = $(IMAGE)-$(ARCH)
@@ -60,8 +58,10 @@ all: all-container
6058

6159
all-push: all-push-images push-manifest
6260

63-
push-manifest: manifest-tool
64-
manifest-tool push from-args --platforms $(call join_platforms,$(ALL_ARCH)) --template $(IMAGE)-ARCH:$(TAG) --target $(IMAGE):$(TAG)
61+
push-manifest:
62+
docker manifest create --amend $(IMAGE):$(TAG) $(shell echo $(ALL_ARCH) | sed -e "s~[^ ]*~$(IMAGE)\-&:$(TAG)~g")
63+
set -x; for arch in $(ALL_ARCH); do docker manifest annotate --arch $${arch} ${IMAGE}:${TAG} ${IMAGE}-$${arch}:${TAG}; done
64+
docker manifest push --purge ${IMAGE}:${TAG}
6565

6666
sub-container-%:
6767
$(MAKE) ARCH=$* container

hack/make-rules/Makefile.manifest

Lines changed: 0 additions & 30 deletions
This file was deleted.

test/images/Makefile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
include ../../hack/make-rules/Makefile.manifest
16-
1715
REGISTRY ?= gcr.io/kubernetes-e2e-test-images
1816
GOARM ?= 7
1917
QEMUVERSION=v2.9.1

0 commit comments

Comments
 (0)