Skip to content

Commit 1ebf64d

Browse files
authored
Merge pull request kubernetes#94896 from wawa0210/fix-92383
Support kubectl alpha debug default image imagePullPolicy set by the image tag
2 parents 0d1ac16 + 6709d4f commit 1ebf64d

File tree

12 files changed

+38
-1
lines changed

12 files changed

+38
-1
lines changed

pkg/apis/apps/v1/zz_generated.defaults.go

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/apis/apps/v1beta1/zz_generated.defaults.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/apis/apps/v1beta2/zz_generated.defaults.go

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/apis/batch/v1/zz_generated.defaults.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/apis/batch/v1beta1/zz_generated.defaults.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/apis/batch/v2alpha1/zz_generated.defaults.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/apis/core/fuzzer/fuzzer.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -301,6 +301,11 @@ var Funcs = func(codecs runtimeserializer.CodecFactory) []interface{} {
301301
ct.TerminationMessagePath = "/" + ct.TerminationMessagePath // Must be non-empty
302302
ct.TerminationMessagePolicy = "File"
303303
},
304+
func(ep *core.EphemeralContainer, c fuzz.Continue) {
305+
c.FuzzNoCustom(ep) // fuzz self without calling this function again
306+
ep.EphemeralContainerCommon.TerminationMessagePath = "/" + ep.TerminationMessagePath // Must be non-empty
307+
ep.EphemeralContainerCommon.TerminationMessagePolicy = "File"
308+
},
304309
func(p *core.Probe, c fuzz.Continue) {
305310
c.FuzzNoCustom(p)
306311
// These fields have default values.

pkg/apis/core/v1/defaults.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,10 @@ func SetDefaults_Container(obj *v1.Container) {
9696
}
9797
}
9898

99+
func SetDefaults_EphemeralContainer(obj *v1.EphemeralContainer) {
100+
SetDefaults_Container((*v1.Container)(&obj.EphemeralContainerCommon))
101+
}
102+
99103
func SetDefaults_Service(obj *v1.Service) {
100104
if obj.Spec.SessionAffinity == "" {
101105
obj.Spec.SessionAffinity = v1.ServiceAffinityNone

pkg/apis/core/v1/defaults_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ func TestWorkloadDefaults(t *testing.T) {
8080
".Spec.Containers[0].TerminationMessagePolicy": `"File"`,
8181
".Spec.DNSPolicy": `"ClusterFirst"`,
8282
".Spec.EphemeralContainers[0].EphemeralContainerCommon.Env[0].ValueFrom.FieldRef.APIVersion": `"v1"`,
83+
".Spec.EphemeralContainers[0].EphemeralContainerCommon.ImagePullPolicy": `"IfNotPresent"`,
8384
".Spec.EphemeralContainers[0].EphemeralContainerCommon.Lifecycle.PostStart.HTTPGet.Path": `"/"`,
8485
".Spec.EphemeralContainers[0].EphemeralContainerCommon.Lifecycle.PostStart.HTTPGet.Scheme": `"HTTP"`,
8586
".Spec.EphemeralContainers[0].EphemeralContainerCommon.Lifecycle.PreStop.HTTPGet.Path": `"/"`,
@@ -103,6 +104,8 @@ func TestWorkloadDefaults(t *testing.T) {
103104
".Spec.EphemeralContainers[0].EphemeralContainerCommon.StartupProbe.PeriodSeconds": "10",
104105
".Spec.EphemeralContainers[0].EphemeralContainerCommon.StartupProbe.SuccessThreshold": "1",
105106
".Spec.EphemeralContainers[0].EphemeralContainerCommon.StartupProbe.TimeoutSeconds": "1",
107+
".Spec.EphemeralContainers[0].EphemeralContainerCommon.TerminationMessagePath": `"/dev/termination-log"`,
108+
".Spec.EphemeralContainers[0].EphemeralContainerCommon.TerminationMessagePolicy": `"File"`,
106109
".Spec.InitContainers[0].Env[0].ValueFrom.FieldRef.APIVersion": `"v1"`,
107110
".Spec.InitContainers[0].ImagePullPolicy": `"IfNotPresent"`,
108111
".Spec.InitContainers[0].Lifecycle.PostStart.HTTPGet.Path": `"/"`,
@@ -203,6 +206,7 @@ func TestPodDefaults(t *testing.T) {
203206
".Spec.DNSPolicy": `"ClusterFirst"`,
204207
".Spec.EnableServiceLinks": `true`,
205208
".Spec.EphemeralContainers[0].EphemeralContainerCommon.Env[0].ValueFrom.FieldRef.APIVersion": `"v1"`,
209+
".Spec.EphemeralContainers[0].EphemeralContainerCommon.ImagePullPolicy": `"IfNotPresent"`,
206210
".Spec.EphemeralContainers[0].EphemeralContainerCommon.Lifecycle.PostStart.HTTPGet.Path": `"/"`,
207211
".Spec.EphemeralContainers[0].EphemeralContainerCommon.Lifecycle.PostStart.HTTPGet.Scheme": `"HTTP"`,
208212
".Spec.EphemeralContainers[0].EphemeralContainerCommon.Lifecycle.PreStop.HTTPGet.Path": `"/"`,
@@ -226,6 +230,8 @@ func TestPodDefaults(t *testing.T) {
226230
".Spec.EphemeralContainers[0].EphemeralContainerCommon.StartupProbe.PeriodSeconds": "10",
227231
".Spec.EphemeralContainers[0].EphemeralContainerCommon.StartupProbe.SuccessThreshold": "1",
228232
".Spec.EphemeralContainers[0].EphemeralContainerCommon.StartupProbe.TimeoutSeconds": "1",
233+
".Spec.EphemeralContainers[0].EphemeralContainerCommon.TerminationMessagePath": `"/dev/termination-log"`,
234+
".Spec.EphemeralContainers[0].EphemeralContainerCommon.TerminationMessagePolicy": `"File"`,
229235
".Spec.InitContainers[0].Env[0].ValueFrom.FieldRef.APIVersion": `"v1"`,
230236
".Spec.InitContainers[0].ImagePullPolicy": `"IfNotPresent"`,
231237
".Spec.InitContainers[0].Lifecycle.PostStart.HTTPGet.Path": `"/"`,

pkg/apis/core/v1/zz_generated.defaults.go

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)