Skip to content

Commit 2059ad6

Browse files
authored
Merge pull request kubernetes#87548 from skilxn-go/AddLoging
Add logging to scheduler's event handlers
2 parents d1dd6cb + 24844c5 commit 2059ad6

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

pkg/scheduler/eventhandlers.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ func (sched *Scheduler) addNodeToCache(obj interface{}) {
100100
klog.Errorf("scheduler cache AddNode failed: %v", err)
101101
}
102102

103+
klog.V(3).Infof("add event for node %q", node.Name)
103104
sched.SchedulingQueue.MoveAllToActiveOrBackoffQueue(queue.NodeAdd)
104105
}
105106

@@ -147,6 +148,7 @@ func (sched *Scheduler) deleteNodeFromCache(obj interface{}) {
147148
klog.Errorf("cannot convert to *v1.Node: %v", t)
148149
return
149150
}
151+
klog.V(3).Infof("delete event for node %q", node.Name)
150152
// NOTE: Updates must be written to scheduler cache before invalidating
151153
// equivalence cache, because we could snapshot equivalence cache after the
152154
// invalidation and then snapshot the cache itself. If the cache is
@@ -166,7 +168,9 @@ func (sched *Scheduler) onCSINodeUpdate(oldObj, newObj interface{}) {
166168
}
167169

168170
func (sched *Scheduler) addPodToSchedulingQueue(obj interface{}) {
169-
if err := sched.SchedulingQueue.Add(obj.(*v1.Pod)); err != nil {
171+
pod := obj.(*v1.Pod)
172+
klog.V(3).Infof("add event for unscheduled pod %s/%s", pod.Namespace, pod.Name)
173+
if err := sched.SchedulingQueue.Add(pod); err != nil {
170174
utilruntime.HandleError(fmt.Errorf("unable to queue %T: %v", obj, err))
171175
}
172176
}
@@ -197,6 +201,7 @@ func (sched *Scheduler) deletePodFromSchedulingQueue(obj interface{}) {
197201
utilruntime.HandleError(fmt.Errorf("unable to handle object in %T: %T", sched, obj))
198202
return
199203
}
204+
klog.V(3).Infof("delete event for unscheduled pod %s/%s", pod.Namespace, pod.Name)
200205
if err := sched.SchedulingQueue.Delete(pod); err != nil {
201206
utilruntime.HandleError(fmt.Errorf("unable to dequeue %T: %v", obj, err))
202207
}
@@ -213,6 +218,7 @@ func (sched *Scheduler) addPodToCache(obj interface{}) {
213218
klog.Errorf("cannot convert to *v1.Pod: %v", obj)
214219
return
215220
}
221+
klog.V(3).Infof("add event for scheduled pod %s/%s ", pod.Namespace, pod.Name)
216222

217223
if err := sched.SchedulerCache.AddPod(pod); err != nil {
218224
klog.Errorf("scheduler cache AddPod failed: %v", err)
@@ -261,6 +267,7 @@ func (sched *Scheduler) deletePodFromCache(obj interface{}) {
261267
klog.Errorf("cannot convert to *v1.Pod: %v", t)
262268
return
263269
}
270+
klog.V(3).Infof("delete event for scheduled pod %s/%s ", pod.Namespace, pod.Name)
264271
// NOTE: Updates must be written to scheduler cache before invalidating
265272
// equivalence cache, because we could snapshot equivalence cache after the
266273
// invalidation and then snapshot the cache itself. If the cache is

0 commit comments

Comments
 (0)