Skip to content

Commit 2260d97

Browse files
authored
Merge pull request kubernetes#90994 from thockin/fix_license_again
Fix umask better
2 parents e5aabae + 8d7adb7 commit 2260d97

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

build/common.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,9 @@ function kube::build::verify_prereqs() {
164164

165165
kube::version::get_version_vars
166166
kube::version::save_version_vars "${KUBE_ROOT}/.dockerized-kube-version-defs"
167+
168+
# Without this, the user's umask can leak through.
169+
umask 0022
167170
}
168171

169172
# ---------------------------------------------------------------------------

hack/lib/golang.sh

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -523,10 +523,6 @@ kube::golang::setup_env() {
523523

524524
# This seems to matter to some tools
525525
export GO15VENDOREXPERIMENT=1
526-
527-
# This is for sanity. Without it, user umasks leak through into release
528-
# artifacts.
529-
umask 0022
530526
}
531527

532528
# This will take binaries from $GOPATH/bin and copy them to the appropriate
@@ -678,6 +674,9 @@ kube::golang::build_some_binaries() {
678674
}
679675

680676
kube::golang::build_binaries_for_platform() {
677+
# This is for sanity. Without it, user umasks can leak through.
678+
umask 0022
679+
681680
local platform=$1
682681

683682
local -a statics=()

0 commit comments

Comments
 (0)