Skip to content

Commit 2293b47

Browse files
committed
add some comments for const variable
1 parent 47d5c3e commit 2293b47

File tree

3 files changed

+20
-20
lines changed

3 files changed

+20
-20
lines changed

pkg/kubelet/sysctl/namespace.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,28 +25,28 @@ type Namespace string
2525

2626
const (
2727
// the Linux IPC namespace
28-
IpcNamespace = Namespace("ipc")
28+
ipcNamespace = Namespace("ipc")
2929

3030
// the network namespace
31-
NetNamespace = Namespace("net")
31+
netNamespace = Namespace("net")
3232

3333
// the zero value if no namespace is known
34-
UnknownNamespace = Namespace("")
34+
unknownNamespace = Namespace("")
3535
)
3636

3737
var namespaces = map[string]Namespace{
38-
"kernel.sem": IpcNamespace,
38+
"kernel.sem": ipcNamespace,
3939
}
4040

4141
var prefixNamespaces = map[string]Namespace{
42-
"kernel.shm": IpcNamespace,
43-
"kernel.msg": IpcNamespace,
44-
"fs.mqueue.": IpcNamespace,
45-
"net.": NetNamespace,
42+
"kernel.shm": ipcNamespace,
43+
"kernel.msg": ipcNamespace,
44+
"fs.mqueue.": ipcNamespace,
45+
"net.": netNamespace,
4646
}
4747

4848
// NamespacedBy returns the namespace of the Linux kernel for a sysctl, or
49-
// UnknownNamespace if the sysctl is not known to be namespaced.
49+
// unknownNamespace if the sysctl is not known to be namespaced.
5050
func NamespacedBy(val string) Namespace {
5151
if ns, found := namespaces[val]; found {
5252
return ns
@@ -56,5 +56,5 @@ func NamespacedBy(val string) Namespace {
5656
return ns
5757
}
5858
}
59-
return UnknownNamespace
59+
return unknownNamespace
6060
}

pkg/kubelet/sysctl/namespace_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ import (
2222

2323
func TestNamespacedBy(t *testing.T) {
2424
tests := map[string]Namespace{
25-
"kernel.shm_rmid_forced": IpcNamespace,
26-
"net.a.b.c": NetNamespace,
27-
"fs.mqueue.a.b.c": IpcNamespace,
28-
"foo": UnknownNamespace,
25+
"kernel.shm_rmid_forced": ipcNamespace,
26+
"net.a.b.c": netNamespace,
27+
"fs.mqueue.a.b.c": ipcNamespace,
28+
"foo": unknownNamespace,
2929
}
3030

3131
for sysctl, ns := range tests {

pkg/kubelet/sysctl/whitelist.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,13 @@ func NewWhitelist(patterns []string) (*patternWhitelist, error) {
5858
if strings.HasSuffix(s, "*") {
5959
prefix := s[:len(s)-1]
6060
ns := NamespacedBy(prefix)
61-
if ns == UnknownNamespace {
61+
if ns == unknownNamespace {
6262
return nil, fmt.Errorf("the sysctls %q are not known to be namespaced", s)
6363
}
6464
w.prefixes[prefix] = ns
6565
} else {
6666
ns := NamespacedBy(s)
67-
if ns == UnknownNamespace {
67+
if ns == unknownNamespace {
6868
return nil, fmt.Errorf("the sysctl %q are not known to be namespaced", s)
6969
}
7070
w.sysctls[s] = ns
@@ -83,20 +83,20 @@ func NewWhitelist(patterns []string) (*patternWhitelist, error) {
8383
func (w *patternWhitelist) validateSysctl(sysctl string, hostNet, hostIPC bool) error {
8484
nsErrorFmt := "%q not allowed with host %s enabled"
8585
if ns, found := w.sysctls[sysctl]; found {
86-
if ns == IpcNamespace && hostIPC {
86+
if ns == ipcNamespace && hostIPC {
8787
return fmt.Errorf(nsErrorFmt, sysctl, ns)
8888
}
89-
if ns == NetNamespace && hostNet {
89+
if ns == netNamespace && hostNet {
9090
return fmt.Errorf(nsErrorFmt, sysctl, ns)
9191
}
9292
return nil
9393
}
9494
for p, ns := range w.prefixes {
9595
if strings.HasPrefix(sysctl, p) {
96-
if ns == IpcNamespace && hostIPC {
96+
if ns == ipcNamespace && hostIPC {
9797
return fmt.Errorf(nsErrorFmt, sysctl, ns)
9898
}
99-
if ns == NetNamespace && hostNet {
99+
if ns == netNamespace && hostNet {
100100
return fmt.Errorf(nsErrorFmt, sysctl, ns)
101101
}
102102
return nil

0 commit comments

Comments
 (0)