Skip to content

Commit 2301a3b

Browse files
committed
cleanup test code in lifecycle, servicecatalog and ui package
1 parent 1afcd7d commit 2301a3b

File tree

14 files changed

+61
-68
lines changed

14 files changed

+61
-68
lines changed

test/e2e/lifecycle/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ go_library(
3737
"//test/e2e/framework/ginkgowrapper:go_default_library",
3838
"//test/e2e/framework/kubelet:go_default_library",
3939
"//test/e2e/framework/lifecycle:go_default_library",
40-
"//test/e2e/framework/log:go_default_library",
4140
"//test/e2e/framework/node:go_default_library",
4241
"//test/e2e/framework/pod:go_default_library",
4342
"//test/e2e/framework/ssh:go_default_library",

test/e2e/lifecycle/addon_update.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import (
2929
"k8s.io/apimachinery/pkg/labels"
3030
clientset "k8s.io/client-go/kubernetes"
3131
"k8s.io/kubernetes/test/e2e/framework"
32-
e2elog "k8s.io/kubernetes/test/e2e/framework/log"
32+
3333
e2essh "k8s.io/kubernetes/test/e2e/framework/ssh"
3434

3535
"github.com/onsi/ginkgo"
@@ -299,7 +299,7 @@ var _ = SIGDescribe("Addon update", func() {
299299
sshExecAndVerify(sshClient, fmt.Sprintf("sudo cp %s/%s %s/%s", temporaryRemotePath, svcAddonEnsureExists, destinationDir, svcAddonEnsureExists))
300300
// Delete the "ensure exist class" addon at the end.
301301
defer func() {
302-
e2elog.Logf("Cleaning up ensure exist class addon.")
302+
framework.Logf("Cleaning up ensure exist class addon.")
303303
err := f.ClientSet.CoreV1().Services(addonNsName).Delete("addon-ensure-exists-test", nil)
304304
framework.ExpectNoError(err)
305305
}()
@@ -392,7 +392,7 @@ func sshExecAndVerify(client *ssh.Client, cmd string) {
392392
}
393393

394394
func sshExec(client *ssh.Client, cmd string) (string, string, int, error) {
395-
e2elog.Logf("Executing '%s' on %v", cmd, client.RemoteAddr())
395+
framework.Logf("Executing '%s' on %v", cmd, client.RemoteAddr())
396396
session, err := client.NewSession()
397397
if err != nil {
398398
return "", "", 0, fmt.Errorf("error creating session to host %s: '%v'", client.RemoteAddr(), err)
@@ -424,7 +424,7 @@ func sshExec(client *ssh.Client, cmd string) (string, string, int, error) {
424424
}
425425

426426
func writeRemoteFile(sshClient *ssh.Client, data, dir, fileName string, mode os.FileMode) error {
427-
e2elog.Logf(fmt.Sprintf("Writing remote file '%s/%s' on %v", dir, fileName, sshClient.RemoteAddr()))
427+
framework.Logf(fmt.Sprintf("Writing remote file '%s/%s' on %v", dir, fileName, sshClient.RemoteAddr()))
428428
session, err := sshClient.NewSession()
429429
if err != nil {
430430
return fmt.Errorf("error creating session to host %s: '%v'", sshClient.RemoteAddr(), err)

test/e2e/lifecycle/bootstrap/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ go_library(
2121
"//staging/src/k8s.io/client-go/kubernetes:go_default_library",
2222
"//staging/src/k8s.io/cluster-bootstrap/token/api:go_default_library",
2323
"//test/e2e/framework:go_default_library",
24-
"//test/e2e/framework/log:go_default_library",
2524
"//test/e2e/lifecycle:go_default_library",
2625
"//vendor/github.com/onsi/ginkgo:go_default_library",
2726
],

test/e2e/lifecycle/bootstrap/util.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ import (
2929
clientset "k8s.io/client-go/kubernetes"
3030
bootstrapapi "k8s.io/cluster-bootstrap/token/api"
3131
"k8s.io/kubernetes/test/e2e/framework"
32-
e2elog "k8s.io/kubernetes/test/e2e/framework/log"
3332
)
3433

3534
func newTokenSecret(tokenID, tokenSecret string) *v1.Secret {
@@ -84,7 +83,7 @@ func WaitforSignedClusterInfoByBootStrapToken(c clientset.Interface, tokenID str
8483
return wait.Poll(framework.Poll, 2*time.Minute, func() (bool, error) {
8584
cfgMap, err := c.CoreV1().ConfigMaps(metav1.NamespacePublic).Get(bootstrapapi.ConfigMapClusterInfo, metav1.GetOptions{})
8685
if err != nil {
87-
e2elog.Failf("Failed to get cluster-info configMap: %v", err)
86+
framework.Failf("Failed to get cluster-info configMap: %v", err)
8887
return false, err
8988
}
9089
_, ok := cfgMap.Data[bootstrapapi.JWSSignatureKeyPrefix+tokenID]
@@ -100,7 +99,7 @@ func WaitForSignedClusterInfoGetUpdatedByBootstrapToken(c clientset.Interface, t
10099
return wait.Poll(framework.Poll, 2*time.Minute, func() (bool, error) {
101100
cfgMap, err := c.CoreV1().ConfigMaps(metav1.NamespacePublic).Get(bootstrapapi.ConfigMapClusterInfo, metav1.GetOptions{})
102101
if err != nil {
103-
e2elog.Failf("Failed to get cluster-info configMap: %v", err)
102+
framework.Failf("Failed to get cluster-info configMap: %v", err)
104103
return false, err
105104
}
106105
updated, ok := cfgMap.Data[bootstrapapi.JWSSignatureKeyPrefix+tokenID]
@@ -116,7 +115,7 @@ func WaitForSignedClusterInfoByBootstrapTokenToDisappear(c clientset.Interface,
116115
return wait.Poll(framework.Poll, 2*time.Minute, func() (bool, error) {
117116
cfgMap, err := c.CoreV1().ConfigMaps(metav1.NamespacePublic).Get(bootstrapapi.ConfigMapClusterInfo, metav1.GetOptions{})
118117
if err != nil {
119-
e2elog.Failf("Failed to get cluster-info configMap: %v", err)
118+
framework.Failf("Failed to get cluster-info configMap: %v", err)
120119
return false, err
121120
}
122121
_, ok := cfgMap.Data[bootstrapapi.JWSSignatureKeyPrefix+tokenID]

test/e2e/lifecycle/ha_master.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@ import (
2828
clientset "k8s.io/client-go/kubernetes"
2929
"k8s.io/kubernetes/test/e2e/common"
3030
"k8s.io/kubernetes/test/e2e/framework"
31-
e2elog "k8s.io/kubernetes/test/e2e/framework/log"
31+
3232
e2epod "k8s.io/kubernetes/test/e2e/framework/pod"
3333
)
3434

3535
func addMasterReplica(zone string) error {
36-
e2elog.Logf(fmt.Sprintf("Adding a new master replica, zone: %s", zone))
36+
framework.Logf(fmt.Sprintf("Adding a new master replica, zone: %s", zone))
3737
_, _, err := framework.RunCmd(path.Join(framework.TestContext.RepoRoot, "hack/e2e-internal/e2e-grow-cluster.sh"), zone, "true", "true", "false")
3838
if err != nil {
3939
return err
@@ -42,7 +42,7 @@ func addMasterReplica(zone string) error {
4242
}
4343

4444
func removeMasterReplica(zone string) error {
45-
e2elog.Logf(fmt.Sprintf("Removing an existing master replica, zone: %s", zone))
45+
framework.Logf(fmt.Sprintf("Removing an existing master replica, zone: %s", zone))
4646
_, _, err := framework.RunCmd(path.Join(framework.TestContext.RepoRoot, "hack/e2e-internal/e2e-shrink-cluster.sh"), zone, "true", "false", "false")
4747
if err != nil {
4848
return err
@@ -51,7 +51,7 @@ func removeMasterReplica(zone string) error {
5151
}
5252

5353
func addWorkerNodes(zone string) error {
54-
e2elog.Logf(fmt.Sprintf("Adding worker nodes, zone: %s", zone))
54+
framework.Logf(fmt.Sprintf("Adding worker nodes, zone: %s", zone))
5555
_, _, err := framework.RunCmd(path.Join(framework.TestContext.RepoRoot, "hack/e2e-internal/e2e-grow-cluster.sh"), zone, "true", "false", "true")
5656
if err != nil {
5757
return err
@@ -60,7 +60,7 @@ func addWorkerNodes(zone string) error {
6060
}
6161

6262
func removeWorkerNodes(zone string) error {
63-
e2elog.Logf(fmt.Sprintf("Removing worker nodes, zone: %s", zone))
63+
framework.Logf(fmt.Sprintf("Removing worker nodes, zone: %s", zone))
6464
_, _, err := framework.RunCmd(path.Join(framework.TestContext.RepoRoot, "hack/e2e-internal/e2e-shrink-cluster.sh"), zone, "true", "true", "true")
6565
if err != nil {
6666
return err
@@ -83,7 +83,7 @@ func findRegionForZone(zone string) string {
8383
region, err := exec.Command("gcloud", "compute", "zones", "list", zone, "--quiet", "--format=csv[no-heading](region)").Output()
8484
framework.ExpectNoError(err)
8585
if string(region) == "" {
86-
e2elog.Failf("Region not found; zone: %s", zone)
86+
framework.Failf("Region not found; zone: %s", zone)
8787
}
8888
return string(region)
8989
}

test/e2e/lifecycle/kubelet_security.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import (
2929
"github.com/onsi/ginkgo"
3030
"github.com/onsi/gomega"
3131
e2ekubelet "k8s.io/kubernetes/test/e2e/framework/kubelet"
32-
e2elog "k8s.io/kubernetes/test/e2e/framework/log"
32+
3333
e2enode "k8s.io/kubernetes/test/e2e/framework/node"
3434
)
3535

@@ -82,7 +82,7 @@ func portClosedTest(f *framework.Framework, pickNode *v1.Node, port int) {
8282
conn, err := net.DialTimeout("tcp", fmt.Sprintf("%s:%d", addr, port), 1*time.Minute)
8383
if err == nil {
8484
conn.Close()
85-
e2elog.Failf("port %d is not disabled", port)
85+
framework.Failf("port %d is not disabled", port)
8686
}
8787
}
8888
}

test/e2e/lifecycle/node_lease.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import (
2525
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2626
clientset "k8s.io/client-go/kubernetes"
2727
"k8s.io/kubernetes/test/e2e/framework"
28-
e2elog "k8s.io/kubernetes/test/e2e/framework/log"
28+
2929
e2enode "k8s.io/kubernetes/test/e2e/framework/node"
3030
e2epod "k8s.io/kubernetes/test/e2e/framework/pod"
3131

@@ -47,7 +47,7 @@ var _ = SIGDescribe("[Disruptive]NodeLease", func() {
4747
gomega.Expect(err).To(gomega.BeNil())
4848
systemPodsNo = int32(len(systemPods))
4949
if strings.Index(framework.TestContext.CloudConfig.NodeInstanceGroup, ",") >= 0 {
50-
e2elog.Failf("Test dose not support cluster setup with more than one MIG: %s", framework.TestContext.CloudConfig.NodeInstanceGroup)
50+
framework.Failf("Test dose not support cluster setup with more than one MIG: %s", framework.TestContext.CloudConfig.NodeInstanceGroup)
5151
} else {
5252
group = framework.TestContext.CloudConfig.NodeInstanceGroup
5353
}
@@ -70,7 +70,7 @@ var _ = SIGDescribe("[Disruptive]NodeLease", func() {
7070

7171
ginkgo.By("restoring the original node instance group size")
7272
if err := framework.ResizeGroup(group, int32(framework.TestContext.CloudConfig.NumNodes)); err != nil {
73-
e2elog.Failf("Couldn't restore the original node instance group size: %v", err)
73+
framework.Failf("Couldn't restore the original node instance group size: %v", err)
7474
}
7575
// In GKE, our current tunneling setup has the potential to hold on to a broken tunnel (from a
7676
// rebooted/deleted node) for up to 5 minutes before all tunnels are dropped and recreated.
@@ -85,11 +85,11 @@ var _ = SIGDescribe("[Disruptive]NodeLease", func() {
8585
time.Sleep(5 * time.Minute)
8686
}
8787
if err := framework.WaitForGroupSize(group, int32(framework.TestContext.CloudConfig.NumNodes)); err != nil {
88-
e2elog.Failf("Couldn't restore the original node instance group size: %v", err)
88+
framework.Failf("Couldn't restore the original node instance group size: %v", err)
8989
}
9090

9191
if err := e2enode.WaitForReadyNodes(c, framework.TestContext.CloudConfig.NumNodes, 10*time.Minute); err != nil {
92-
e2elog.Failf("Couldn't restore the original cluster size: %v", err)
92+
framework.Failf("Couldn't restore the original cluster size: %v", err)
9393
}
9494
// Many e2e tests assume that the cluster is fully healthy before they start. Wait until
9595
// the cluster is restored to health.
@@ -111,7 +111,7 @@ var _ = SIGDescribe("[Disruptive]NodeLease", func() {
111111
pass := true
112112
for _, node := range originalNodes.Items {
113113
if _, err := leaseClient.Get(node.ObjectMeta.Name, metav1.GetOptions{}); err != nil {
114-
e2elog.Logf("Try to get lease of node %s, but got error: %v", node.ObjectMeta.Name, err)
114+
framework.Logf("Try to get lease of node %s, but got error: %v", node.ObjectMeta.Name, err)
115115
pass = false
116116
}
117117
}

test/e2e/lifecycle/reboot.go

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import (
3030
clientset "k8s.io/client-go/kubernetes"
3131
api "k8s.io/kubernetes/pkg/apis/core"
3232
"k8s.io/kubernetes/test/e2e/framework"
33-
e2elog "k8s.io/kubernetes/test/e2e/framework/log"
33+
3434
e2enode "k8s.io/kubernetes/test/e2e/framework/node"
3535
e2epod "k8s.io/kubernetes/test/e2e/framework/pod"
3636
e2essh "k8s.io/kubernetes/test/e2e/framework/ssh"
@@ -74,7 +74,7 @@ var _ = SIGDescribe("Reboot [Disruptive] [Feature:Reboot]", func() {
7474
framework.ExpectNoError(err)
7575

7676
for _, e := range events.Items {
77-
e2elog.Logf("event for %v: %v %v: %v", e.InvolvedObject.Name, e.Source, e.Reason, e.Message)
77+
framework.Logf("event for %v: %v %v: %v", e.InvolvedObject.Name, e.Source, e.Reason, e.Message)
7878
}
7979
}
8080
// In GKE, our current tunneling setup has the potential to hold on to a broken tunnel (from a
@@ -138,7 +138,7 @@ func testReboot(c clientset.Interface, rebootCmd string, hook terminationHook) {
138138
nodelist := framework.GetReadySchedulableNodesOrDie(c)
139139
if hook != nil {
140140
defer func() {
141-
e2elog.Logf("Executing termination hook on nodes")
141+
framework.Logf("Executing termination hook on nodes")
142142
hook(framework.TestContext.Provider, nodelist)
143143
}()
144144
}
@@ -165,10 +165,10 @@ func testReboot(c clientset.Interface, rebootCmd string, hook terminationHook) {
165165
for ix := range nodelist.Items {
166166
n := nodelist.Items[ix]
167167
if !result[ix] {
168-
e2elog.Logf("Node %s failed reboot test.", n.ObjectMeta.Name)
168+
framework.Logf("Node %s failed reboot test.", n.ObjectMeta.Name)
169169
}
170170
}
171-
e2elog.Failf("Test failed; at least one node failed to reboot in the time given.")
171+
framework.Failf("Test failed; at least one node failed to reboot in the time given.")
172172
}
173173
}
174174

@@ -179,9 +179,9 @@ func printStatusAndLogsForNotReadyPods(c clientset.Interface, ns string, podName
179179
prefix = "Retrieving log for the last terminated container"
180180
}
181181
if err != nil {
182-
e2elog.Logf("%s %s, err: %v:\n%s\n", prefix, id, err, log)
182+
framework.Logf("%s %s, err: %v:\n%s\n", prefix, id, err, log)
183183
} else {
184-
e2elog.Logf("%s %s:\n%s\n", prefix, id, log)
184+
framework.Logf("%s %s:\n%s\n", prefix, id, log)
185185
}
186186
}
187187
podNameSet := sets.NewString(podNames...)
@@ -195,7 +195,7 @@ func printStatusAndLogsForNotReadyPods(c clientset.Interface, ns string, podName
195195
if ok, _ := testutils.PodRunningReady(p); ok {
196196
continue
197197
}
198-
e2elog.Logf("Status for not ready pod %s/%s: %+v", p.Namespace, p.Name, p.Status)
198+
framework.Logf("Status for not ready pod %s/%s: %+v", p.Namespace, p.Name, p.Status)
199199
// Print the log of the containers if pod is not running and ready.
200200
for _, container := range p.Status.ContainerStatuses {
201201
cIdentifer := fmt.Sprintf("%s/%s/%s", p.Namespace, p.Name, container.Name)
@@ -224,16 +224,16 @@ func rebootNode(c clientset.Interface, provider, name, rebootCmd string) bool {
224224
ns := metav1.NamespaceSystem
225225
ps, err := testutils.NewPodStore(c, ns, labels.Everything(), fields.OneTermEqualSelector(api.PodHostField, name))
226226
if err != nil {
227-
e2elog.Logf("Couldn't initialize pod store: %v", err)
227+
framework.Logf("Couldn't initialize pod store: %v", err)
228228
return false
229229
}
230230
defer ps.Stop()
231231

232232
// Get the node initially.
233-
e2elog.Logf("Getting %s", name)
233+
framework.Logf("Getting %s", name)
234234
node, err := c.CoreV1().Nodes().Get(name, metav1.GetOptions{})
235235
if err != nil {
236-
e2elog.Logf("Couldn't get node %s", name)
236+
framework.Logf("Couldn't get node %s", name)
237237
return false
238238
}
239239

@@ -258,7 +258,7 @@ func rebootNode(c clientset.Interface, provider, name, rebootCmd string) bool {
258258
podNames = append(podNames, p.ObjectMeta.Name)
259259
}
260260
}
261-
e2elog.Logf("Node %s has %d assigned pods with no liveness probes: %v", name, len(podNames), podNames)
261+
framework.Logf("Node %s has %d assigned pods with no liveness probes: %v", name, len(podNames), podNames)
262262

263263
// For each pod, we do a sanity check to ensure it's running / healthy
264264
// or succeeded now, as that's what we'll be checking later.
@@ -269,7 +269,7 @@ func rebootNode(c clientset.Interface, provider, name, rebootCmd string) bool {
269269

270270
// Reboot the node.
271271
if err = e2essh.IssueSSHCommand(rebootCmd, provider, node); err != nil {
272-
e2elog.Logf("Error while issuing ssh command: %v", err)
272+
framework.Logf("Error while issuing ssh command: %v", err)
273273
return false
274274
}
275275

@@ -291,7 +291,7 @@ func rebootNode(c clientset.Interface, provider, name, rebootCmd string) bool {
291291
return false
292292
}
293293

294-
e2elog.Logf("Reboot successful on node %s", name)
294+
framework.Logf("Reboot successful on node %s", name)
295295
return true
296296
}
297297

@@ -302,7 +302,7 @@ func catLogHook(logPath string) terminationHook {
302302
for _, n := range nodes.Items {
303303
cmd := fmt.Sprintf("cat %v && rm %v", logPath, logPath)
304304
if _, err := e2essh.IssueSSHCommandWithResult(cmd, provider, &n); err != nil {
305-
e2elog.Logf("Error while issuing ssh command: %v", err)
305+
framework.Logf("Error while issuing ssh command: %v", err)
306306
}
307307
}
308308

test/e2e/lifecycle/resize_nodes.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import (
2525
clientset "k8s.io/client-go/kubernetes"
2626
"k8s.io/kubernetes/test/e2e/common"
2727
"k8s.io/kubernetes/test/e2e/framework"
28-
e2elog "k8s.io/kubernetes/test/e2e/framework/log"
28+
2929
e2enode "k8s.io/kubernetes/test/e2e/framework/node"
3030
e2epod "k8s.io/kubernetes/test/e2e/framework/pod"
3131

@@ -56,7 +56,7 @@ var _ = SIGDescribe("Nodes [Disruptive]", func() {
5656
framework.ExpectNoError(err)
5757
systemPodsNo = int32(len(systemPods))
5858
if strings.Index(framework.TestContext.CloudConfig.NodeInstanceGroup, ",") >= 0 {
59-
e2elog.Failf("Test dose not support cluster setup with more than one MIG: %s", framework.TestContext.CloudConfig.NodeInstanceGroup)
59+
framework.Failf("Test dose not support cluster setup with more than one MIG: %s", framework.TestContext.CloudConfig.NodeInstanceGroup)
6060
} else {
6161
group = framework.TestContext.CloudConfig.NodeInstanceGroup
6262
}
@@ -81,7 +81,7 @@ var _ = SIGDescribe("Nodes [Disruptive]", func() {
8181

8282
ginkgo.By("restoring the original node instance group size")
8383
if err := framework.ResizeGroup(group, int32(framework.TestContext.CloudConfig.NumNodes)); err != nil {
84-
e2elog.Failf("Couldn't restore the original node instance group size: %v", err)
84+
framework.Failf("Couldn't restore the original node instance group size: %v", err)
8585
}
8686
// In GKE, our current tunneling setup has the potential to hold on to a broken tunnel (from a
8787
// rebooted/deleted node) for up to 5 minutes before all tunnels are dropped and recreated.
@@ -96,11 +96,11 @@ var _ = SIGDescribe("Nodes [Disruptive]", func() {
9696
time.Sleep(5 * time.Minute)
9797
}
9898
if err := framework.WaitForGroupSize(group, int32(framework.TestContext.CloudConfig.NumNodes)); err != nil {
99-
e2elog.Failf("Couldn't restore the original node instance group size: %v", err)
99+
framework.Failf("Couldn't restore the original node instance group size: %v", err)
100100
}
101101

102102
if err := e2enode.WaitForReadyNodes(c, int(originalNodeCount), 10*time.Minute); err != nil {
103-
e2elog.Failf("Couldn't restore the original cluster size: %v", err)
103+
framework.Failf("Couldn't restore the original cluster size: %v", err)
104104
}
105105
// Many e2e tests assume that the cluster is fully healthy before they start. Wait until
106106
// the cluster is restored to health.

0 commit comments

Comments
 (0)