Skip to content

Commit 2347da8

Browse files
authored
Merge pull request kubernetes#76378 from cwdsuzhou/clean_up_codes_in_scheduler
clean up unused code in scheduler
2 parents e8fc79d + 4c12c76 commit 2347da8

File tree

6 files changed

+1
-23
lines changed

6 files changed

+1
-23
lines changed

pkg/scheduler/eventhandlers.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@ import (
2424
"k8s.io/api/core/v1"
2525
storagev1 "k8s.io/api/storage/v1"
2626
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
27-
appsinformers "k8s.io/client-go/informers/apps/v1"
2827
coreinformers "k8s.io/client-go/informers/core/v1"
29-
policyinformers "k8s.io/client-go/informers/policy/v1beta1"
3028
storageinformers "k8s.io/client-go/informers/storage/v1"
3129
"k8s.io/client-go/tools/cache"
3230
)
@@ -325,11 +323,7 @@ func AddAllEventHandlers(
325323
podInformer coreinformers.PodInformer,
326324
pvInformer coreinformers.PersistentVolumeInformer,
327325
pvcInformer coreinformers.PersistentVolumeClaimInformer,
328-
replicationControllerInformer coreinformers.ReplicationControllerInformer,
329-
replicaSetInformer appsinformers.ReplicaSetInformer,
330-
statefulSetInformer appsinformers.StatefulSetInformer,
331326
serviceInformer coreinformers.ServiceInformer,
332-
pdbInformer policyinformers.PodDisruptionBudgetInformer,
333327
storageClassInformer storageinformers.StorageClassInformer,
334328
) {
335329
// scheduled pod cache

pkg/scheduler/scheduler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ func New(client clientset.Interface,
196196
// Create the scheduler.
197197
sched := NewFromConfig(config)
198198

199-
AddAllEventHandlers(sched, options.schedulerName, nodeInformer, podInformer, pvInformer, pvcInformer, replicationControllerInformer, replicaSetInformer, statefulSetInformer, serviceInformer, pdbInformer, storageClassInformer)
199+
AddAllEventHandlers(sched, options.schedulerName, nodeInformer, podInformer, pvInformer, pvcInformer, serviceInformer, storageClassInformer)
200200
return sched, nil
201201
}
202202

test/integration/daemonset/daemonset_test.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,11 +130,7 @@ func setupScheduler(
130130
informerFactory.Core().V1().Pods(),
131131
informerFactory.Core().V1().PersistentVolumes(),
132132
informerFactory.Core().V1().PersistentVolumeClaims(),
133-
informerFactory.Core().V1().ReplicationControllers(),
134-
informerFactory.Apps().V1().ReplicaSets(),
135-
informerFactory.Apps().V1().StatefulSets(),
136133
informerFactory.Core().V1().Services(),
137-
informerFactory.Policy().V1beta1().PodDisruptionBudgets(),
138134
informerFactory.Storage().V1().StorageClasses(),
139135
)
140136

test/integration/scheduler/scheduler_test.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -611,11 +611,7 @@ func TestMultiScheduler(t *testing.T) {
611611
podInformer2,
612612
context.informerFactory.Core().V1().PersistentVolumes(),
613613
context.informerFactory.Core().V1().PersistentVolumeClaims(),
614-
context.informerFactory.Core().V1().ReplicationControllers(),
615-
context.informerFactory.Apps().V1().ReplicaSets(),
616-
context.informerFactory.Apps().V1().StatefulSets(),
617614
context.informerFactory.Core().V1().Services(),
618-
context.informerFactory.Policy().V1beta1().PodDisruptionBudgets(),
619615
context.informerFactory.Storage().V1().StorageClasses(),
620616
)
621617

test/integration/scheduler/util.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -198,11 +198,7 @@ func initTestSchedulerWithOptions(
198198
podInformer,
199199
context.informerFactory.Core().V1().PersistentVolumes(),
200200
context.informerFactory.Core().V1().PersistentVolumeClaims(),
201-
context.informerFactory.Core().V1().ReplicationControllers(),
202-
context.informerFactory.Apps().V1().ReplicaSets(),
203-
context.informerFactory.Apps().V1().StatefulSets(),
204201
context.informerFactory.Core().V1().Services(),
205-
context.informerFactory.Policy().V1beta1().PodDisruptionBudgets(),
206202
context.informerFactory.Storage().V1().StorageClasses(),
207203
)
208204

test/integration/util/util.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,7 @@ func StartScheduler(clientSet clientset.Interface) (factory.Configurator, Shutdo
8282
informerFactory.Core().V1().Pods(),
8383
informerFactory.Core().V1().PersistentVolumes(),
8484
informerFactory.Core().V1().PersistentVolumeClaims(),
85-
informerFactory.Core().V1().ReplicationControllers(),
86-
informerFactory.Apps().V1().ReplicaSets(),
87-
informerFactory.Apps().V1().StatefulSets(),
8885
informerFactory.Core().V1().Services(),
89-
informerFactory.Policy().V1beta1().PodDisruptionBudgets(),
9086
informerFactory.Storage().V1().StorageClasses(),
9187
)
9288

0 commit comments

Comments
 (0)