Skip to content

Commit 2369ef0

Browse files
Promote service exclusion and legacy node role to beta
We did not promote these to beta in 1.18 but will do so in 1.19. As per the KEP we do not set disable LegacyNodeRoleBehavior to false until 1.20.
1 parent 342d328 commit 2369ef0

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

pkg/features/kube_features.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,18 +146,21 @@ const (
146146

147147
// owner @smarterclayton
148148
// alpha: v1.16
149+
// beta: v1.19
149150
//
150151
// Enable legacy behavior to vary cluster functionality on the node-role.kubernetes.io labels. On by default (legacy), will be turned off in 1.18.
151152
LegacyNodeRoleBehavior featuregate.Feature = "LegacyNodeRoleBehavior"
152153

153154
// owner @brendandburns
154155
// alpha: v1.9
156+
// beta: v1.19
155157
//
156158
// Enable nodes to exclude themselves from service load balancers
157159
ServiceNodeExclusion featuregate.Feature = "ServiceNodeExclusion"
158160

159161
// owner @smarterclayton
160162
// alpha: v1.16
163+
// beta: v1.19
161164
//
162165
// Enable nodes to exclude themselves from network disruption checks
163166
NodeDisruptionExclusion featuregate.Feature = "NodeDisruptionExclusion"
@@ -597,8 +600,8 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS
597600
CPUManager: {Default: true, PreRelease: featuregate.Beta},
598601
CPUCFSQuotaPeriod: {Default: false, PreRelease: featuregate.Alpha},
599602
TopologyManager: {Default: true, PreRelease: featuregate.Beta},
600-
ServiceNodeExclusion: {Default: false, PreRelease: featuregate.Alpha},
601-
NodeDisruptionExclusion: {Default: false, PreRelease: featuregate.Alpha},
603+
ServiceNodeExclusion: {Default: true, PreRelease: featuregate.Beta},
604+
NodeDisruptionExclusion: {Default: true, PreRelease: featuregate.Beta},
602605
CSIDriverRegistry: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.20
603606
CSINodeInfo: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.19
604607
BlockVolume: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.20
@@ -674,5 +677,5 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS
674677
// features that enable backwards compatibility but are scheduled to be removed
675678
// ...
676679
HPAScaleToZero: {Default: false, PreRelease: featuregate.Alpha},
677-
LegacyNodeRoleBehavior: {Default: true, PreRelease: featuregate.Alpha},
680+
LegacyNodeRoleBehavior: {Default: true, PreRelease: featuregate.Beta},
678681
}

0 commit comments

Comments
 (0)