Skip to content

Commit 24469a3

Browse files
authored
Merge pull request kubernetes#86585 from SataQiu/scheduler-taint-toleration
"Move Taint and toleration priority to its Score plugin"
2 parents 0c54ec3 + 21c916c commit 24469a3

File tree

13 files changed

+115
-342
lines changed

13 files changed

+115
-342
lines changed

pkg/scheduler/algorithm/priorities/BUILD

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ go_library(
2222
"resource_allocation.go",
2323
"resource_limits.go",
2424
"selector_spreading.go",
25-
"taint_toleration.go",
2625
"test_util.go",
2726
"types.go",
2827
],
@@ -62,7 +61,6 @@ go_test(
6261
"resource_limits_test.go",
6362
"selector_spreading_test.go",
6463
"spreading_perf_test.go",
65-
"taint_toleration_test.go",
6664
"types_test.go",
6765
],
6866
embed = [":go_default_library"],

pkg/scheduler/algorithm/priorities/metadata.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ func NewMetadataFactory(
5757
// priorityMetadata is a type that is passed as metadata for priority functions
5858
type priorityMetadata struct {
5959
podLimits *schedulernodeinfo.Resource
60-
podTolerations []v1.Toleration
6160
affinity *v1.Affinity
6261
podSelector labels.Selector
6362
controllerRef *metav1.OwnerReference
@@ -88,7 +87,6 @@ func (pmf *MetadataFactory) PriorityMetadata(
8887
}
8988
return &priorityMetadata{
9089
podLimits: getResourceLimits(pod),
91-
podTolerations: getAllTolerationPreferNoSchedule(pod.Spec.Tolerations),
9290
affinity: pod.Spec.Affinity,
9391
podSelector: getSelector(pod, pmf.serviceLister, pmf.controllerLister, pmf.replicaSetLister, pmf.statefulSetLister),
9492
controllerRef: metav1.GetControllerOf(pod),

pkg/scheduler/algorithm/priorities/metadata_test.go

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -138,30 +138,27 @@ func TestPriorityMetadata(t *testing.T) {
138138
{
139139
pod: podWithTolerationsAndAffinity,
140140
expected: &priorityMetadata{
141-
podLimits: nonPodLimits,
142-
podTolerations: tolerations,
143-
affinity: podAffinity,
144-
podSelector: labels.NewSelector(),
141+
podLimits: nonPodLimits,
142+
affinity: podAffinity,
143+
podSelector: labels.NewSelector(),
145144
},
146145
name: "Produce a priorityMetadata with default requests",
147146
},
148147
{
149148
pod: podWithTolerationsAndRequests,
150149
expected: &priorityMetadata{
151-
podLimits: nonPodLimits,
152-
podTolerations: tolerations,
153-
affinity: nil,
154-
podSelector: labels.NewSelector(),
150+
podLimits: nonPodLimits,
151+
affinity: nil,
152+
podSelector: labels.NewSelector(),
155153
},
156154
name: "Produce a priorityMetadata with tolerations and requests",
157155
},
158156
{
159157
pod: podWithAffinityAndRequests,
160158
expected: &priorityMetadata{
161-
podLimits: specifiedPodLimits,
162-
podTolerations: nil,
163-
affinity: podAffinity,
164-
podSelector: labels.NewSelector(),
159+
podLimits: specifiedPodLimits,
160+
affinity: podAffinity,
161+
podSelector: labels.NewSelector(),
165162
},
166163
name: "Produce a priorityMetadata with affinity and requests",
167164
},

pkg/scheduler/algorithm/priorities/taint_toleration.go

Lines changed: 0 additions & 76 deletions
This file was deleted.

pkg/scheduler/algorithm/priorities/taint_toleration_test.go

Lines changed: 0 additions & 241 deletions
This file was deleted.

0 commit comments

Comments
 (0)